Skip to content

ROX-29860: replace pgtype with pgx/v5#15855

Merged
janisz merged 1 commit intomasterfrom
remove_pgtype
Jul 1, 2025
Merged

ROX-29860: replace pgtype with pgx/v5#15855
janisz merged 1 commit intomasterfrom
remove_pgtype

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Jun 27, 2025

Description

pgx/v5 comes with pgtype so there is no need to use legacy version.

@janisz janisz requested a review from a team June 27, 2025 10:32
@janisz janisz requested a review from a team as a code owner June 27, 2025 10:32
@red-hat-konflux
Copy link
Copy Markdown
Contributor

red-hat-konflux bot commented Jun 27, 2025

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
quay-proxy no kind "ImageDigestMirrorSet" is registered for version "config.openshift.io/v1" in scheme "k8s.io/client-go/kubernetes/scheme/register.go:83"

@janisz janisz mentioned this pull request Jun 27, 2025
Merged
4 tasks
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Jun 27, 2025 •
edited
Loading

Images are ready for the commit at 0e05770.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-144-g0e057703b8.

@janisz janisz requested review from RTann and rhybrillou June 27, 2025 12:38
Base automatically changed from ROX-29860 to master June 27, 2025 20:11
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Jun 27, 2025 •
edited
Loading

@janisz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-scanner-v4-install-tests ac92a76 link false /test gke-scanner-v4-install-tests
ci/prow/ocp-4-12-scanner-v4-install-tests ac92a76 link false /test ocp-4-12-scanner-v4-install-tests
ci/prow/ocp-4-18-scanner-v4-install-tests ac92a76 link false /test ocp-4-18-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz
ROX-29860: replace pgtype with pgx/v5
0e05770 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.80%. Comparing base (1bf201f) to head (0e05770).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/search/postgres/query_metadata.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #15855   +/-   ##
=======================================
  Coverage   48.80%   48.80%           
=======================================
  Files        2589     2589           
  Lines      190567   190567           
=======================================
  Hits        93014    93014           
+ Misses      90245    90244    -1     
- Partials     7308     7309    +1
Flag Coverage Δ
go-unit-tests 48.80% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

RTann
RTann reviewed Jun 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@RTann RTann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about any backwards compatibility with old numeric types previously stored in the DB?

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Jul 1, 2025

What are "old numeric types"?

@janisz janisz merged commit fa12c68 into master Jul 1, 2025
92 of 93 checks passed
@janisz janisz deleted the remove_pgtype branch July 1, 2025 16:13
@RTann
Copy link
Copy Markdown
Contributor

RTann commented Jul 1, 2025 •
edited
Loading

Do we need to worry about any backwards compatibility with old numeric types previously stored in the DB?

What are "old numeric types"?

Perhaps I'm just unfamiliar with how the data is stored in the DB. I figured we were storing numeric types in the DB as *github.com/jackc/pgtype.Numeric. Since that struct is not quite compatible with *github.com/jackc/v5/pgtype.Numeric, I'm not sure if the check for Valid will work (since that field doesn't exist in the original struct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

@dashrews78 dashrews78 dashrews78 approved these changes

+1 more reviewer

@RTann RTann RTann left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@janisz @rhacs-bot @RTann @rhybrillou @dashrews78