Conversation
There was a problem hiding this comment.
Hey @RTann - I've reviewed your changes - here's some feedback:
- Run
go mod tidyto remove the now-unused indirectgithub.com/jackc/pgx/v4requirement and ensure no stale pgx/v4 references remain. - Double-check that all pgx/v5 API changes (connection pool Acquire/Release, Exec/Query signatures, etc.) are correctly applied and no v4 method calls persist.
- After bumping
ctxlockto v2, verify that lock semantics and concurrency behavior in your indexer and matcher routines haven’t regressed.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Run `go mod tidy` to remove the now-unused indirect `github.com/jackc/pgx/v4` requirement and ensure no stale pgx/v4 references remain.
- Double-check that all pgx/v5 API changes (connection pool Acquire/Release, Exec/Query signatures, etc.) are correctly applied and no v4 method calls persist.
- After bumping `ctxlock` to v2, verify that lock semantics and concurrency behavior in your indexer and matcher routines haven’t regressed.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Caution There are some errors in your PipelineRun template.
|
|
Images are ready for the commit at 6598909. To use with deploy scripts, first |
|
We can get rid of |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15851 +/- ##
==========================================
- Coverage 48.80% 48.79% -0.01%
==========================================
Files 2591 2591
Lines 190614 190614
==========================================
- Hits 93023 93019 -4
- Misses 90289 90292 +3
- Partials 7302 7303 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@RTann: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-4.8 release-4.8
# Navigate to the new working tree
cd .worktrees/backport-release-4.8
# Create a new branch
git switch --create backport-15851-to-release-4.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2fe63904442805243a5e081cd856220a7f4d9832
# Push it to GitHub
git push --set-upstream origin backport-15851-to-release-4.8
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-4.8Then, create a pull request where the |
Description
pgx/v4 reaches EOL soon. Claircore has already bumped its pgx version to v5. We used v4 solely because Claircore did. Now that is doesn't, let's update our Claircore version and update our own usage of pgx to v5, too.
Note: the
ctxlockpackage was also updated tov2for the related Claircore change, so updating it here, tooUser-facing documentation
Testing and quality
Automated testing
no
How I validated my change
If it builds, it builds