fix: Take first of $FUNCNAME in check-konflux-setup.sh#15866
Conversation
|
Skipping CI for Draft Pull Request. |
|
Caution There are some errors in your PipelineRun template.
|
|
Images are ready for the commit at 33edf78. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15866 +/- ##
==========================================
- Coverage 48.80% 48.79% -0.01%
==========================================
Files 2589 2589
Lines 190588 190588
==========================================
- Hits 93011 92994 -17
- Misses 90276 90288 +12
- Partials 7301 7306 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@msugakov: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest blah |
Description
In #15818, shellcheck that runs in CI told me that
FUNCNAMEis actually an array and it's no good to access its first element without explicitly telling so. Here's the fix formaster(already applied for 4.6 in137338b(#15818)).I'm a bit left wondering what happened to shellcheck after 4.6 because this issue was not revealed by CI when I was developing the script, but I'll leave this discovery for the future.
User-facing documentation
Testing and quality
Automated testing
No change.
How I validated my change
Tested manually. Broke things a bit in
.tekton/operator-bundle-pipeline.yaml, ranscripts/ci/jobs/check-konflux-setup.shand observed it still prints the failing function name at the end of the output.