Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The new CI triage section added to AGENTS.md largely duplicates the content in triage/README.md—consider trimming AGENTS.md to a brief summary with a link to the detailed triage directory to avoid drift.
- CLAUDE.md is over 1000 lines long; splitting it into smaller, topic-focused documents or adding a clear table of contents would make it easier to navigate.
- In the MCP Atlassian setup examples, please clearly mark all token values as placeholders (e.g.,
<YOUR_TOKEN>) to avoid any confusion or accidental credential exposure.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new CI triage section added to AGENTS.md largely duplicates the content in triage/README.md—consider trimming AGENTS.md to a brief summary with a link to the detailed triage directory to avoid drift.
- CLAUDE.md is over 1000 lines long; splitting it into smaller, topic-focused documents or adding a clear table of contents would make it easier to navigate.
- In the MCP Atlassian setup examples, please clearly mark all token values as placeholders (e.g., `<YOUR_TOKEN>`) to avoid any confusion or accidental credential exposure.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 3e02a24. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16691 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 2696 2696
Lines 201446 201446
=======================================
+ Hits 98310 98316 +6
+ Misses 95378 95374 -4
+ Partials 7758 7756 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
porridge
requested changes
Sep 9, 2025
- Fix AGENTS.md to reference triage/ directory instead of artifacts/ - Add Claude Code documentation link - Clarify MCP server configuration instructions - Update artifacts download path to triage/ROX-XXXXX-analysis/ - Clarify JIRA access is to Red Hat instance - Improve workflow documentation clarity Addresses feedback from @porridge in PR review.
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
janisz
commented
Sep 15, 2025
janisz
commented
Sep 15, 2025
janisz
commented
Sep 15, 2025
janisz
commented
Sep 15, 2025
janisz
commented
Sep 15, 2025
porridge
reviewed
Sep 16, 2025
Contributor
porridge
left a comment
There was a problem hiding this comment.
I think this needs some basic readme file explaining how to get started.
All I see is:
Contributor
Author
|
That's my idea no readme everything happens automatically. Have you tried to triage something using this branch? |
Contributor
|
That's my point. How do I try triaging something using this branch? |
Contributor
Author
That's the goal. Just start claude and ask it to triage. We don't have a readme how to use AGENTS.md. The goal is to make it transparent. |
mtodor
approved these changes
Sep 18, 2025
Co-authored-by: Mladen Todorovic <mtodor@gmail.com>
Co-authored-by: Mladen Todorovic <mtodor@gmail.com>
- Fix typo: mcp-atllasian → mcp-atlassian in links and references - Update JIRA URL from redhat.atlassian.net to issues.redhat.com - Improve casing consistency: PROW MCP → Prow MCP - Remove automatic flaky test identification to prevent unwanted restarts - Optimize artifact analysis workflow to prefer local downloads over remote browsing - Remove gsutil ls commands in favor of direct file downloads for better performance 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Remove explicit MCP tool names from auto-actions section. Now ROX-XXXXX format automatically triggers JIRA investigation without specifying the exact tool, making the agent more flexible and pattern-based. Addresses PR review comment about implicit pattern detection vs explicit tool specification. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
@porridge PTAL |
porridge
reviewed
Sep 22, 2025
Contributor
porridge
left a comment
There was a problem hiding this comment.
I think to hope for some adoption, the setup needs to be really simple. I spent 12 minutes just reading the docs, without making actual progress :-(
janisz
commented
Sep 22, 2025
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Co-authored-by: Tomasz Janiszewski <tomek@redhat.com>
porridge
reviewed
Sep 22, 2025
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.anthropic.com/en/docs/claude-code/sub-agents
Triaged:
Co-Authored: Claude noreply@anthropic.com