Conversation
57491e6 to
254a069
Compare
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
254a069 to
c0547d8
Compare
Contributor
|
Images are ready for the commit at 34919ca. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16649 +/- ##
==========================================
- Coverage 48.73% 48.62% -0.11%
==========================================
Files 2658 2664 +6
Lines 198307 199298 +991
==========================================
+ Hits 96635 96906 +271
- Misses 94106 94797 +691
- Partials 7566 7595 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtodor
reviewed
Sep 4, 2025
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider adding a quick check to verify that the svc/webhookserver service exists before attempting port-forward to avoid silent failures if the service is missing or misnamed.
- Rather than a fixed sleep after launching the background port-forward, consider polling for the port to be open or checking the process health to ensure readiness more reliably.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a quick check to verify that the svc/webhookserver service exists before attempting port-forward to avoid silent failures if the service is missing or misnamed.
- Rather than a fixed sleep after launching the background port-forward, consider polling for the port to be open or checking the process health to ensure readiness more reliably.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
Author
|
/retest |
Contributor
|
Caution There are some errors in your PipelineRun template.
|
mtodor
approved these changes
Sep 5, 2025
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
|
/retest |
Contributor
|
Images are ready for the commit at 6e9a375. To use with deploy scripts, first |
Contributor
|
/retest |
ksurabhi91
pushed a commit
that referenced
this pull request
Sep 5, 2025
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Let's use service instead of pod in port-forwarder also extend logging to make debugging easier in the future.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!