ROX-30579: Configure process baseline auto locking via operator#16697
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at c0b1eaa. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16697 +/- ##
==========================================
- Coverage 48.79% 48.78% -0.01%
==========================================
Files 2712 2712
Lines 202362 202393 +31
==========================================
Hits 98736 98736
- Misses 95844 95870 +26
- Partials 7782 7787 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a1d98bd to
8bd4d50
Compare
44a4b01 to
978f69e
Compare
d874377 to
f0ef02f
Compare
e3aa5fa to
c9ca7ab
Compare
porridge
left a comment
There was a problem hiding this comment.
You might want to take a fresh look at https://github.com/stackrox/stackrox/blob/master/operator/EXTENDING_CRDS.md we've recently improved it to describe the necessary steps in a more streamlined way, and it also has some new important info on defaults.
More comments inline.
operator/internal/securedcluster/values/translation/translation.go
Outdated
Show resolved
Hide resolved
d3b715e to
0dd72f0
Compare
3dfe3ba to
581c5e7
Compare
porridge
left a comment
There was a problem hiding this comment.
Some comments inline. Also:
- lint is failing due to formatting
- operator build is failing due to dirty repo, not sure why, perhaps one of the base PRs are not clean?
- please follow the
EXTENDING_CRDSchecklist, in particular the pr prep step
operator/internal/securedcluster/values/translation/translation.go
Outdated
Show resolved
Hide resolved
0dd72f0 to
7f31d68
Compare
95e779e to
9ee7e41
Compare
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
…n.go Co-authored-by: Marcin Owsiany <porridge@redhat.com>
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
06153ae to
c0b1eaa
Compare
|
/test gke-upgrade-tests |
Description
Makes it so that the process baseline auto-locking feature can be controlled at the cluster level via the operator.
This PR is built on top of
Configure process baseline auto locking via helm
#16462
and
Add process baseline auto locking to cluster config
#16669
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Performed an operator upgrade test using the instructions at https://spaces.redhat.com/pages/viewpage.action?spaceKey=StackRox&title=How+to+test+upstream+OLM+operator+upgrade
Summary
An openshift-4 cluster was created and the 4.8 operator was installed there. It was upgraded to this branch. The cluster config was checked and it was confirmed that process baseline auto-locking was disabled. The securedcluster CR was then edited to enable process baseline auto-locking and it was confirmed that process baseline auto-locking was enabled. The securedcluster CR was then edited to disable process baseline auto-locking and it was confirmed to be disabled.
Details
Created an openshift-4 cluster called jv-0915-ocp and downloaded the artifacts.
Got the password and url of the openshift console
Created the stackrox namespace in the OpenShift console UI.
Created stackrox pull secrets
Created central using the openshift console UI.
Got the password for central
Created a port forward
Logged into localhost:8000 and created and downloaded the init bundle.
Created the secured cluster in the OpenShift console UI.
Checked the state of the system
Did the upgrade
Checked the state of the system again
Checked that the image in central had been updated
Checked the securedcluster CR
The cluster config was checked and it was the following
Note that process baseline auto-locking is disabled.
The spec section of the securedcluster CR was changed to the following
Afterwards sensor restarted
The cluster config was checked again
Note that process baseline auto-locking is now enabled.
The spec section of the securedcluster CR was then changed to the following
Again sensor restarted. The cluster config was checked again and process baseline auto-locking had been disabled.
Fresh install
Followed the directions here https://github.com/stackrox/stackrox/blob/master/operator/README.md#installing-operator-via-olm
ROX_PRODUCT_BRANDING=RHACS_BRANDING make deploy-via-olm
Found the url and password for the OpenShift console UI
Created central
Got the password for central
Created a port forward
Logged into localhost:8000 and created and downloaded the init bundle.
Created the secured cluster in the OpenShift console UI.
Enabled process baseline auto-locking
The cluster config was checked and process baselines auto-locking was enabled.
Process baseline auto-locking was then disabled by editing the secured cluster and the API was checked again to confirm that it was disabled.