ROX-30577: Add process baseline auto locking to cluster config#16669
Conversation
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at f93a916. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16669 +/- ##
==========================================
+ Coverage 48.62% 48.74% +0.11%
==========================================
Files 2664 2677 +13
Lines 199343 200063 +720
==========================================
+ Hits 96929 97517 +588
- Misses 94818 94938 +120
- Partials 7596 7608 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b99522d to
da86bf4
Compare
|
/test gke-nongroovy-e2e-tests |
dashrews78
left a comment
There was a problem hiding this comment.
left a nit otherwise I'm OK with this as long as the config experts are.
pedrottimark
left a comment
There was a problem hiding this comment.
Naming convention in storage/cluster.proto is solid from UI viewpoint and Jouko confirmed details via Slack for small sibling contribution to display on clusters page.
|
@JoukoVirtanen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
clickboo
left a comment
There was a problem hiding this comment.
Reviewed the cluster config changes, lgtm. Thanks @JoukoVirtanen for making suggested changes.
Description
Adds auto locking to the cluster protobuf. Also makes it so that the cluster configuration is used to control auto locking. Thus it will be possible to control process baseline auto locking at the cluster level. The feature flag is still in place and in order to enable process baseline auto locking for a cluster the feature flag needs to be enabled and it needs to be enabled for the cluster via the cluster config.
After this change it will not be possible to control this new cluster field via helm or operator. That will be done in other PRs.
The PR to control process baseline auto-locking via helm can be found here #16462
The PR to control process baseline auto-locking via operator can be found here #16697
This PR replaces #16427
User-facing documentation
Testing and quality
Automated testing
How I validated my change
et the following environment variables
Deployed ACS.
Created a pod that could be used to run some processes and entered it.
Logged into the UI and checked "Risk".
The process baseline was still unlocked after more than five minutes.
Ran the following script to enable process baseline auto locking for the cluster
Created another pod, entered it, and ran a command
Initially the process baseline is unlocked.
After a little more than five minutes the baseline is locked.
Running a new process results in a violation