Conversation
Contributor
Author
|
/test ocp-4-19-qa-e2e-tests |
Contributor
|
Images are ready for the commit at 936feca. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16698 +/- ##
=======================================
Coverage 48.62% 48.62%
=======================================
Files 2664 2664
Lines 199343 199343
=======================================
Hits 96929 96929
- Misses 94818 94819 +1
+ Partials 7596 7595 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dvail
approved these changes
Sep 8, 2025
Contributor
dvail
left a comment
There was a problem hiding this comment.
Test suite passed, hard to argue with the strong evidence in the description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 87b258a.
The test suite
ocp-qa-e2e-testsstarted failing pretty reliably due to an invalid cluster name passed in to a command that sets up workload identity in GCP. The few passing test runs over the last few days are on PRs that haven't rebased in the last few days. The passing PR with the most recent branch from master is #16649, having branched from 34117b8. Sure enough, 87b258a (the commit this PR is reverting) is the commit to master right after 34117b8, and it touches CI shell scripts.If the test suite passes, then that is strong evidence that the revert fixes the issue.