ROX-30894: Display autoLockProcessBaselinesConfig in cluster form#16841
ROX-30894: Display autoLockProcessBaselinesConfig in cluster form#16841pedrottimark merged 1 commit intomasterfrom
Conversation
|
Images are ready for the commit at 0d6b66e. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16841 +/- ##
==========================================
+ Coverage 48.94% 48.96% +0.02%
==========================================
Files 2686 2690 +4
Lines 201250 201445 +195
==========================================
+ Hits 98494 98647 +153
- Misses 95115 95146 +31
- Partials 7641 7652 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@pedrottimark: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Frontend counterpart to #16669
Only planned frontend contribution in support of process baselines feature.
Discussed details with Jouko in Slack thread.
Surprises and Residue
Selection did not work until I added exception in
onChangefunction.The
ifstatement looks dubious.During debugging, I temporarily added
Clustertype tonewClusterDefaultand was able to improve it, but:It lacks some properties that seem irrelevant to manifest installation, but deserve clearer thinking whether to use TypeScript
Omittype utility.https://www.typescriptlang.org/docs/handbook/utility-types.html#omittype-keys
Investigation of TypeScript errors is prerequisite to add
| nullto some properties ofClustertype.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform foldernpm run lint:fast-devin ui/apps/platform foldernpm run startin ui/apps/platform folder with staging demo as centralManual testing
Visit /main/clusters and click link to visit cluster page
With

'ROX_AUTOLOCK_PROCESS_BASELINES'feature flag disabled, see absence of Automatically lock process baselines selection.With

'ROX_AUTOLOCK_PROCESS_BASELINES'feature flag enabled via temporary code change, see presence of Automatically lock process baselines selection Disabled whenautoLockProcessBaselinesConfig: nullin cluster response.For manifest installation method, see Automatically lock process baselines selection itself is enabled, and select Enable to see property set in form values via temporary

JSON.stringifyinconsole.logstatement.