Skip to content

ROX-30894: Display autoLockProcessBaselinesConfig in cluster form#16841

Merged
pedrottimark merged 1 commit intomasterfrom
ROX-30894-autoLockProcessBaselinesConfig
Sep 19, 2025
Merged

ROX-30894: Display autoLockProcessBaselinesConfig in cluster form#16841
pedrottimark merged 1 commit intomasterfrom
ROX-30894-autoLockProcessBaselinesConfig

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Sep 15, 2025

Description

Frontend counterpart to #16669

Only planned frontend contribution in support of process baselines feature.

Discussed details with Jouko in Slack thread.

Surprises and Residue

  1. Selection did not work until I added exception in onChange function.

    The if statement looks dubious.

  2. During debugging, I temporarily added Cluster type to newClusterDefault and was able to improve it, but:

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder
  2. npm run lint:fast-dev in ui/apps/platform folder
  3. npm run start in ui/apps/platform folder with staging demo as central

Manual testing

  1. Visit /main/clusters and click link to visit cluster page

    • With 'ROX_AUTOLOCK_PROCESS_BASELINES' feature flag disabled, see absence of Automatically lock process baselines selection.
      feature_flag_disabled

    • With 'ROX_AUTOLOCK_PROCESS_BASELINES' feature flag enabled via temporary code change, see presence of Automatically lock process baselines selection Disabled when autoLockProcessBaselinesConfig: null in cluster response.
      feature_flag_enabled_prop_is_disabled

      For manifest installation method, see Automatically lock process baselines selection itself is enabled, and select Enable to see property set in form values via temporary JSON.stringify in console.log statement.
      feature_flag_enabled_prop_set_enabled

@pedrottimark pedrottimark requested a review from a team as a code owner September 15, 2025 19:55
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 0d6b66e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-780-g0d6b66e292.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.96%. Comparing base (f824db4) to head (0d6b66e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #16841      +/-   ##
==========================================
+ Coverage   48.94%   48.96%   +0.02%     
==========================================
  Files        2686     2690       +4     
  Lines      201250   201445     +195     
==========================================
+ Hits        98494    98647     +153     
- Misses      95115    95146      +31     
- Partials     7641     7652      +11     
Flag Coverage Δ
go-unit-tests 48.96% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2025

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 0d6b66e link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-19-nongroovy-e2e-tests 0d6b66e link false /test ocp-4-19-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pedrottimark pedrottimark merged commit ad5633d into master Sep 19, 2025
87 of 89 checks passed
@pedrottimark pedrottimark deleted the ROX-30894-autoLockProcessBaselinesConfig branch September 19, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants