ROX-30959: evaluate baseline benchmark#16932
Merged
dashrews78 merged 2 commits intomasterfrom Sep 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Consider using a fixed base time instead of time.Now() in generateProcessIndicators to make benchmark timings deterministic and reproducible.
- Reset or truncate the test database between benchmark iterations since EvaluateBaselinesAndPersistResult persists data and can skew subsequent run results.
- The generateProcessIndicators function is quite large—consider extracting or refactoring it into shared test utilities to improve readability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using a fixed base time instead of time.Now() in generateProcessIndicators to make benchmark timings deterministic and reproducible.
- Reset or truncate the test database between benchmark iterations since EvaluateBaselinesAndPersistResult persists data and can skew subsequent run results.
- The generateProcessIndicators function is quite large—consider extracting or refactoring it into shared test utilities to improve readability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at 4da825a. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16932 +/- ##
==========================================
- Coverage 49.02% 49.02% -0.01%
==========================================
Files 2691 2691
Lines 201626 201631 +5
==========================================
- Hits 98844 98840 -4
- Misses 95119 95126 +7
- Partials 7663 7665 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Sep 19, 2025
charmik-redhat
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for the rest of epic ROX-30958 we need a benchmark so we can compare results as the improvements are made. Utilized Cursor to create the vast majority of this, iterating through the scenarios and narrowing the scope as we went.
User-facing documentation
Testing and quality
Automated testing
How I validated my change