ROX-30960: add container start time as a column by dashrews78 · Pull Request #16933 · stackrox/stackrox

dashrews78 · 2025-09-19T16:42:36Z

Description

When we evaluate the process indicators against the baseline we pull the entire indicator for the deployment. The indicator can be quite large. We are only looking at 6 fields. To improve our memory footprint as part of epic ROX-30958 we are going to only pull the fields we need. Container start time was the only field that was not already a column. So this PR adds it as a column. Subsequent PRs will add the migration and use the new column.

User-facing documentation

CHANGELOG.md is updated OR update is not needed
documentation PR is created and is linked above OR is not needed

Testing and quality

the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
CI results are inspected

Automated testing

How I validated my change

Simply promoting a field to be a column. CI is sufficient here.

dashrews78 · 2025-09-19T16:42:38Z

This change is part of the following stack:

ROX-30959: evaluate baseline benchmark #16932
- ROX-30960: add container start time as a column #16933 ◀
  - ROX-30961: migration to populate indicator container start time WIP DO NOT REVIEW #16935
    - ROX-30963: Only query indicator fields needed for evalution #16965

_{Change managed by git-spice.}

openshift-ci · 2025-09-19T16:42:41Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

rhacs-bot · 2025-09-19T17:03:22Z

Images are ready for the commit at 92c8cbc.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-868-g92c8cbc720.

codecov · 2025-09-19T17:19:08Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.82%. Comparing base (46f7a70) to head (92c8cbc).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #16933   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files        2693     2693           
  Lines      201342   201345    +3     
=======================================
+ Hits        98310    98312    +2     
+ Misses      95275    95274    -1     
- Partials     7757     7759    +2

Flag	Coverage Δ
go-unit-tests	`48.82% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

dashrews78 · 2025-09-24T14:25:07Z

/retest

red-hat-konflux · 2025-09-24T14:25:19Z

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
central-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
main-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
operator-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
operator-bundle-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-collector	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-db	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner-slim	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
retag-scanner	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
roxctl-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`
scanner-v4-db-on-push	`CEL expression evaluation error: expression "(\n event == \"push\" && target_branch.matches(\"^(master\|release-.\|refs/tags/.)$\")\n) \|\| (\n event == \"pull_request\" && (\n target_branch.startsWith(\"release-\") \|\|\n source_branch.matches(\"(konflux\|renovate\|appstudio\|rhtap)\") \|\|\n (has(body.pull_request.labels) && body.pull_request.labels.exists(l, l.name == \"konflux-build\"))\n ) && body.action != \"ready_for_review\"\n)\n" failed to evaluate: no such key: pull_request`

openshift-ci bot added the do-not-merge/work-in-progress label Sep 19, 2025

github-actions bot added area/central area/postgres labels Sep 19, 2025

This was referenced Sep 19, 2025

ROX-30961: migration to populate indicator container start time WIP DO NOT REVIEW #16935

Closed

ROX-30959: evaluate baseline benchmark #16932

Merged

Base automatically changed from dashrews/evaluate-baseline-benchmark-30959 to master September 22, 2025 09:41

dashrews78 force-pushed the dashrews/container-start-column-30960 branch from 43b8187 to 95eab27 Compare September 22, 2025 13:34

dashrews78 marked this pull request as ready for review September 22, 2025 13:39

dashrews78 requested a review from a team as a code owner September 22, 2025 13:39

openshift-ci bot removed the do-not-merge/work-in-progress label Sep 22, 2025

dashrews78 added the ai-review label Sep 22, 2025

dashrews78 requested review from ajheflin, charmik-redhat, clickboo and ksurabhi91 September 22, 2025 13:39

sourcery-ai bot reviewed Sep 22, 2025

View reviewed changes

clickboo approved these changes Sep 22, 2025

View reviewed changes

dashrews78 mentioned this pull request Sep 22, 2025

ROX-30963: Only query indicator fields needed for evalution #16965

Merged

9 tasks

dashrews78 added 2 commits September 23, 2025 11:01

add container start time as a column

2adc45e

fix test

92c8cbc

dashrews78 force-pushed the dashrews/container-start-column-30960 branch from 6f0c461 to 92c8cbc Compare September 23, 2025 15:02

dashrews78 merged commit 67b48d8 into master Sep 24, 2025
99 checks passed

dashrews78 deleted the dashrews/container-start-column-30960 branch September 24, 2025 16:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ROX-30960: add container start time as a column#16933

ROX-30960: add container start time as a column#16933
dashrews78 merged 2 commits intomasterfrom
dashrews/container-start-column-30960

dashrews78 commented Sep 19, 2025 •

edited

Loading

Uh oh!

dashrews78 commented Sep 19, 2025 •

edited

Loading

Uh oh!

openshift-ci bot commented Sep 19, 2025

Uh oh!

rhacs-bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 19, 2025 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

dashrews78 commented Sep 24, 2025

Uh oh!

red-hat-konflux bot commented Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dashrews78 commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

User-facing documentation

Testing and quality

Automated testing

How I validated my change

Uh oh!

dashrews78 commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Sep 19, 2025

Uh oh!

rhacs-bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

dashrews78 commented Sep 24, 2025

Uh oh!

red-hat-konflux bot commented Sep 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dashrews78 commented Sep 19, 2025 •

edited

Loading

dashrews78 commented Sep 19, 2025 •

edited

Loading

rhacs-bot commented Sep 19, 2025 •

edited

Loading

codecov bot commented Sep 19, 2025 •

edited

Loading