ROX-31023: arm64 support for operator images (2nd)#17140
Merged
mclasmeier merged 8 commits intomasterfrom Oct 14, 2025
Merged
Conversation
|
Skipping CI for Draft Pull Request. |
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
General comments:
- Double-check that the
push_operator_multiarch_manifests.archsmatrix value matches what yourpush_operator_manifest_listsscript expects (CSV vs array) so it actually pushes all arches correctly. - You’re only running operator unit tests on amd64—consider using QEMU to run them on arm64 too so you catch any arch-specific failures earlier.
- There’s a lot of duplicated logic for determining
push_contextand pushing images/manifests; consider extracting that into a shared CI function or action to reduce boilerplate.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check that the `push_operator_multiarch_manifests.archs` matrix value matches what your `push_operator_manifest_lists` script expects (CSV vs array) so it actually pushes all arches correctly.
- You’re only running operator unit tests on amd64—consider using QEMU to run them on arm64 too so you catch any arch-specific failures earlier.
- There’s a lot of duplicated logic for determining `push_context` and pushing images/manifests; consider extracting that into a shared CI function or action to reduce boilerplate.
## Individual Comments
### Comment 1
<location> `.github/workflows/build.yaml:604` </location>
<code_context>
uses: docker/setup-buildx-action@v3
</code_context>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>
### Comment 2
<location> `.github/workflows/build.yaml:645` </location>
<code_context>
uses: docker/setup-qemu-action@v3
</code_context>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Images are ready for the commit at d15f81d. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17140 +/- ##
==========================================
- Coverage 48.84% 48.83% -0.01%
==========================================
Files 2717 2717
Lines 203231 203231
==========================================
- Hits 99261 99253 -8
- Misses 96154 96159 +5
- Partials 7816 7819 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
porridge
approved these changes
Oct 6, 2025
porridge
requested changes
Oct 7, 2025
Co-authored-by: Marcin Owsiany <porridge@redhat.com>
porridge
approved these changes
Oct 7, 2025
vladbologa
reviewed
Oct 7, 2025
Keeping it like this for now for consistency reasons.
tommartensen
approved these changes
Oct 14, 2025
mclasmeier
pushed a commit
that referenced
this pull request
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another attempt at #16915, which got reverted during CI failures on master.
The problems occurring on master before looked like this:
So, on master merges we were missing the "latest" tags for the arch-specific operator images.
Commit d7b0dee addresses this. The rest is the same as the original PR, just rebased on current master.