fix: Mount host directories, allowing to free up more disk space#17278
fix: Mount host directories, allowing to free up more disk space#17278mclasmeier merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/build.yaml:585-586` </location>
<code_context>
- define-job-matrix
container:
image: quay.io/stackrox-io/apollo-ci:stackrox-test-0.4.9
+ volumes:
+ - /usr:/mnt/usr
+ - /opt:/mnt/opt
env:
</code_context>
<issue_to_address>
**issue (bug_risk):** Mounting /usr and /opt as volumes may introduce risk of overwriting system files.
If these mounts are required, ensure container processes do not modify the contents of /usr or /opt.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at 4132ec8. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17278 +/- ##
=======================================
Coverage 48.86% 48.86%
=======================================
Files 2720 2720
Lines 203364 203364
=======================================
+ Hits 99374 99380 +6
+ Misses 96166 96161 -5
+ Partials 7824 7823 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tommartensen
left a comment
There was a problem hiding this comment.
Reached requested free disk space 30 [ 30GB free].
https://github.com/stackrox/stackrox/actions/runs/18496874099/job/52703193342?pr=17278#step:4:177
Previously, this failed to reach the required 30 GB, so this should feel better now.
Description
So, merging #17140 apparently again caused master branch breakage. The operator image building failed on the master branch due to "no space left on device".
This is an attempt at fixing this by leveraging the "mount host directories into container" trick, which seems to allow the
job-preambleto more aggressively delete certain unused tools and thus freeing up more disk space.User-facing documentation & Tests
This is merely a CI fix, nothing user facing -> neither docs, nor tests required for this change.