Skip to content

chore(m2m): remove feature flag#17234

Merged
stehessel merged 1 commit intomasterfrom
chore/remove-m2m-feature-flag
Oct 13, 2025
Merged

chore(m2m): remove feature flag#17234
stehessel merged 1 commit intomasterfrom
chore/remove-m2m-feature-flag

Conversation

@stehessel
Copy link
Collaborator

@stehessel stehessel commented Oct 10, 2025

Description

Remove the m2m feature flag. The feature is now stable.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@openshift-ci
Copy link

openshift-ci bot commented Oct 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 10, 2025 •
edited
Loading

Images are ready for the commit at b15496e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.9.x-1043-gb15496e627.

@stehessel stehessel force-pushed the chore/remove-m2m-feature-flag branch from d048d5d to b15496e Compare October 10, 2025 09:55
@stehessel stehessel marked this pull request as ready for review October 10, 2025 10:18
@stehessel stehessel requested a review from a team as a code owner October 10, 2025 10:18
@codecov
Copy link

codecov bot commented Oct 10, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.85%. Comparing base (9598e78) to head (b15496e).
⚠️ Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
central/auth/service/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #17234      +/-   ##
==========================================
+ Coverage   48.81%   48.85%   +0.03%     
==========================================
  Files        2717     2717              
  Lines      203219   203195      -24     
==========================================
+ Hits        99200    99266      +66     
+ Misses      96196    96122      -74     
+ Partials     7823     7807      -16
Flag Coverage Δ
go-unit-tests 48.85% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91
Copy link
Contributor

vikin91 commented Oct 10, 2025

#17239

vikin91
vikin91 approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vikin91 vikin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vikin91 vikin91 mentioned this pull request Oct 10, 2025
Closed
9 tasks
@stehessel stehessel merged commit 4b0f671 into master Oct 13, 2025
111 of 113 checks passed
@stehessel stehessel deleted the chore/remove-m2m-feature-flag branch October 13, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikin91 vikin91 vikin91 approved these changes

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stehessel @rhacs-bot @vikin91 @rhybrillou