ROX-31236: Remove ROX_AUTH_MACHINE_TO_MACHINE feature flag#17239
Closed
ROX-31236: Remove ROX_AUTH_MACHINE_TO_MACHINE feature flag#17239
Conversation
This removes the ROX_AUTH_MACHINE_TO_MACHINE feature flag that has been enabled by default since Release 4.3 (November 2023). The flag enabled Machine-to-Machine authentication functionality allowing services to exchange ID tokens for Central access tokens without user interaction. This behavior is now the standard and only operational mode. Changes: - Removed feature flag definition from pkg/features/list.go - Removed feature flag checks from 6 API methods in service_impl.go - Removed conditional datastore initialization in service.go - Removed unused m2mFeatureDisabledError() helper function - Removed unused features package imports All M2M authentication functionality remains fully operational. Partially generated with AI assistance.
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 5ca8234. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #17239 +/- ##
==========================================
+ Coverage 48.81% 48.84% +0.03%
==========================================
Files 2717 2717
Lines 203219 203198 -21
==========================================
+ Hits 99200 99258 +58
+ Misses 96196 96131 -65
+ Partials 7823 7809 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
Contributor
Author
|
Closing in favor of #17234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human here
This has been created fully by AI.
I have checked the code changes and the PR description.
Description
This PR removes the
ROX_AUTH_MACHINE_TO_MACHINEfeature flag which has been enabled by default since Release 4.3 (November 2023) - approximately 2 years in production.📋 Detailed Implementation Plan:
REMOVAL_PLAN_AUTH_M2M.md
Why it's safe to remove:
Removal Sequence Justification
This is the second PR of 4 in the feature flag removal sequence.
Position in sequence: SECOND (Parallel track - independent)
Why this order:
ROX_PREVENT_SENSOR_RESTART_ON_DISCONNECTflag #17236 (ROX_PREVENT_SENSOR_RESTART_ON_DISCONNECT)Dependencies:
Reference: See attached
REMOVAL_PLAN_AUTH_M2M.mdfor complete analysis.Files modified:
Suggested reviewers: (AI got it wrong)
User-facing documentation
Testing and quality
Automated testing
How I validated my change