ROX-33563: Migrate scanner image to ubi-micro#17430
Conversation
|
Images are ready for the commit at e5ba21f. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17430 +/- ##
==========================================
+ Coverage 49.28% 49.32% +0.04%
==========================================
Files 2735 2737 +2
Lines 206215 206445 +230
==========================================
+ Hits 101633 101838 +205
- Misses 97041 97062 +21
- Partials 7541 7545 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
The scanner-v4-indexer and scanner-v4-matcher containers were crashing immediately with exit code 1 because the migration to ubi8-micro removed essential shell utilities that the entrypoint scripts depend on. Root cause: - entrypoint.sh uses #!/usr/bin/env bash - ubi8-micro has no utilities pre-installed (unlike ubi8-minimal) - The container fails immediately when trying to execute the bash script This fix applies the same multi-stage build pattern used in: - PR #17406 for the main image - commit cc55af9 for scanner-v4-db Changes: 1. Added dependency_builder stage using ubi8 (full) 2. Install bash, coreutils, findutils, util-linux, ca-certificates to /out/ 3. Copy dependencies from builder to ubi8-micro final stage 4. Removed microdnf/rpm operations from final stage (not available in ubi8-micro) 5. Changed BASE_IMAGE from ubi8-minimal to ubi8-micro This enables the entrypoint scripts to execute successfully while maintaining the minimal footprint of ubi8-micro. Fixes: ROX-30858 Related: #17406, #17430 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
Images are ready for the commit at 39afde2. To use with deploy scripts, first |
The scanner-v4-indexer and scanner-v4-matcher containers were crashing immediately with exit code 1 because the migration to ubi8-micro removed essential shell utilities that the entrypoint scripts depend on. Root cause: - entrypoint.sh uses #!/usr/bin/env bash - ubi8-micro has no utilities pre-installed (unlike ubi8-minimal) - The container fails immediately when trying to execute the bash script This fix applies the same multi-stage build pattern used in: - PR #17406 for the main image - commit cc55af9 for scanner-v4-db Changes: 1. Added dependency_builder stage using ubi8 (full) 2. Install bash, coreutils, findutils, util-linux, ca-certificates to /out/ 3. Copy dependencies from builder to ubi8-micro final stage 4. Removed microdnf/rpm operations from final stage (not available in ubi8-micro) 5. Changed BASE_IMAGE from ubi8-minimal to ubi8-micro This enables the entrypoint scripts to execute successfully while maintaining the minimal footprint of ubi8-micro. Fixes: ROX-30858 Related: #17406, #17430 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
7ec8ef2 to
8761059
Compare
The scanner-v4-indexer and scanner-v4-matcher containers were crashing immediately with exit code 1 because the migration to ubi8-micro removed essential shell utilities that the entrypoint scripts depend on. Root cause: - entrypoint.sh uses #!/usr/bin/env bash - ubi8-micro has no utilities pre-installed (unlike ubi8-minimal) - The container fails immediately when trying to execute the bash script This fix applies the same multi-stage build pattern used in: - PR #17406 for the main image - commit cc55af9 for scanner-v4-db Changes: 1. Added dependency_builder stage using ubi8 (full) 2. Install bash, coreutils, findutils, util-linux, ca-certificates to /out/ 3. Copy dependencies from builder to ubi8-micro final stage 4. Removed microdnf/rpm operations from final stage (not available in ubi8-micro) 5. Changed BASE_IMAGE from ubi8-minimal to ubi8-micro This enables the entrypoint scripts to execute successfully while maintaining the minimal footprint of ubi8-micro. Fixes: ROX-30858 Related: #17406, #17430 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
53adcac to
400c63d
Compare
scanner/image/scanner/Dockerfile
Outdated
| ARG MAPPINGS_REGISTRY=registry.access.redhat.com | ||
| ARG MAPPINGS_BASE_IMAGE=ubi8 | ||
| ARG MAPPINGS_BASE_TAG=latest | ||
| ARG RPMS_REGISTRY=registry.access.redhat.com | ||
| ARG RPMS_BASE_IMAGE=ubi8 | ||
| ARG RPMS_BASE_TAG=latest | ||
| ARG BASE_REGISTRY=registry.access.redhat.com | ||
| ARG BASE_IMAGE=ubi8-minimal | ||
| ARG BASE_IMAGE=ubi8-micro | ||
| ARG BASE_TAG=latest |
There was a problem hiding this comment.
If the scanner team does not object, I suggest getting rid of these ARGs similar to how I described here #17406 (comment)
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Co-authored-by: Misha Sugakov <537715+msugakov@users.noreply.github.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 28930366 | Triggered | Generic High Entropy Secret | 557483a | sensor/kubernetes/fake/secret.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Complete scanner UBI 9 upgrade while preserving ubi-micro architecture. Resolved conflicts in scanner Dockerfiles: - Updated all ubi8 references to ubi9 - Updated releasever from 8 to 9 - Preserved package_installer pattern with ubi9/ubi-micro - Updated save-dir-contents path to /etc/pki/ca-trust/source - Kept direct FROM statements (not ARG-based) User request: merge master and resolve conflicts after UBI 9 upgrade. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Images are ready for the commit at 48486bb. To use with deploy scripts, first |
dcaravel
left a comment
There was a problem hiding this comment.
Few nits for consideration - also believe title of PR should read ubi9-micro (currently says ubi8)
Thanks for taking care of this!
…eed them Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
|
/retest |
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
|
/retest |
|
/retest |
|
@janisz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Migrate scanner images from ubi8-minimal to ubi8-micro following the same best practices used for collector migration.
Tested:
Then check in UI if everything is healthy and followed and check if scanner is working