ROX-32615: Add no-non-deprecated-JavaScript lint rule with ignores#18443
Merged
pedrottimark merged 1 commit intomasterfrom Mar 19, 2026
Merged
Conversation
Contributor
|
Images are ready for the commit at b4fb2ff. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18443 +/- ##
=======================================
Coverage 49.27% 49.27%
=======================================
Files 2726 2726
Lines 205625 205625
=======================================
+ Hits 101312 101319 +7
+ Misses 96777 96772 -5
+ Partials 7536 7534 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
ui-e2e-tests failure has been fixed in #18422
|
sachaudh
approved these changes
Feb 24, 2026
16a5fe3 to
b4fb2ff
Compare
This was referenced Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opportunity
Suggestion by Saif that we rewrite reside of JavaScript files in TypeScript.
TL;DR only about 15 candidates
Problem
Distinguish which JavaScript files need rewrite in TypeScript:
Analysis
In
ui/apps/platformfolder:Solution
Use typescript-eslint playground to see that
Programis type of root node.https://typescript-eslint.io/play/#ts=5.9.3&showAST=es&fileType=.tsx
Read that return value of
path.extnameincludes period.https://nodejs.org/docs/latest/api/path.html#pathextnamepath
Add
triage-JavaScript-TypeScriptlint rule/tool to document file or folders:// deprecated// rewrite// research// deferredDelete obsolete src/mockData/baselineStatuses.js file.
Delete files which content can move into only one file that uses it.
Move files used in only one container folder.
Fix one error for moved file from
no-logical-or-preceding-array-or-objectrule.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.