ROX-33689: Rewrite Docs container files in TypeScript#19528
Open
pedrottimark wants to merge 1 commit intomasterfrom
Open
ROX-33689: Rewrite Docs container files in TypeScript#19528pedrottimark wants to merge 1 commit intomasterfrom
pedrottimark wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at 454dbc8. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19528 +/- ##
==========================================
+ Coverage 49.23% 49.24% +0.01%
==========================================
Files 2727 2727
Lines 205764 205787 +23
==========================================
+ Hits 101306 101345 +39
+ Misses 96920 96906 -14
+ Partials 7538 7536 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Review: Hide space because indentation change.
Follow up lint rule/tool to identify a few non-deprecated JavaScript files in #18443
Because typescript-eslint no-floating-promises error for
fetchDatacall, I rewrote body ofuseEffecthook as promise handling instead of async await.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.Manual testing
Visit /main/dashboard
Click ? and then API Reference (v1)
Click ? and then API Reference (v2)