Skip to content

ROX-32757: added LayerType#18580

Merged
daynewlee merged 5 commits intomasterfrom
yli3/fromImageType
Jan 27, 2026
Merged

ROX-32757: added LayerType#18580
daynewlee merged 5 commits intomasterfrom
yli3/fromImageType

Conversation

@daynewlee
Copy link
Contributor

@daynewlee daynewlee commented Jan 21, 2026 •
edited
Loading

Description

Field type change is necessary for the front end

bool from_base_image = 15 [deprecated = true];
LayerType layer_type = 16; // @gotags: search:"Component Layer Type,hidden"

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Will be added

@daynewlee daynewlee requested a review from a team as a code owner January 21, 2026 00:31
@daynewlee daynewlee changed the title added LayerType ROX-32757: added LayerType Jan 21, 2026
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 21, 2026 •
edited
Loading

Images are ready for the commit at 36a29c1.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-910-g36a29c1142.

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 21, 2026

Images are ready for the commit at 15f5502.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-833-g533ba70def.

@daynewlee daynewlee force-pushed the yli3/fromImageType branch 5 times, most recently from 90244f3 to 4f2b700 Compare January 21, 2026 20:57
@codecov
Copy link

codecov bot commented Jan 21, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.22%. Comparing base (2aa69b2) to head (2d3d65c).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...magecomponent/v2/datastore/store/postgres/store.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #18580   +/-   ##
=======================================
  Coverage   49.21%   49.22%           
=======================================
  Files        2658     2658           
  Lines      199650   199656    +6     
=======================================
+ Hits        98265    98285   +20     
+ Misses      93955    93943   -12     
+ Partials     7430     7428    -2
Flag Coverage Δ
go-unit-tests 49.22% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sachaudh
sachaudh reviewed Jan 22, 2026
View reviewed changes
c-du
c-du reviewed Jan 22, 2026
View reviewed changes
@daynewlee daynewlee force-pushed the yli3/fromImageType branch 3 times, most recently from 2d3d65c to efa66ea Compare January 23, 2026 14:46
@daynewlee daynewlee requested review from c-du and sachaudh January 23, 2026 14:53
c-du
c-du approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@c-du c-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM. Please check @sachaudh before merging.

@openshift-ci
Copy link

openshift-ci bot commented Jan 27, 2026 •
edited
Loading

@daynewlee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 36a29c1 link false /test ocp-4-12-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@daynewlee daynewlee merged commit 1cd5080 into master Jan 27, 2026
99 of 100 checks passed
@daynewlee daynewlee deleted the yli3/fromImageType branch January 27, 2026 14:44
@pedrottimark pedrottimark mentioned this pull request Jan 27, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-du c-du c-du approved these changes

@jvdm jvdm Awaiting requested review from jvdm

@ksurabhi91 ksurabhi91 Awaiting requested review from ksurabhi91

@sachaudh sachaudh Awaiting requested review from sachaudh

@pedrottimark pedrottimark Awaiting requested review from pedrottimark

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@daynewlee @rhacs-bot @sachaudh @pedrottimark @c-du