ROX-32837: Re-align layer type filter with backend search term#18709
Merged
pedrottimark merged 1 commit intomasterfrom Jan 28, 2026
Merged
ROX-32837: Re-align layer type filter with backend search term#18709pedrottimark merged 1 commit intomasterfrom
pedrottimark merged 1 commit intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at bd8840a. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18709 +/- ##
=======================================
Coverage 49.37% 49.38%
=======================================
Files 2659 2659
Lines 200358 200358
=======================================
+ Hits 98931 98939 +8
+ Misses 93985 93978 -7
+ Partials 7442 7441 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test gke-nongroovy-e2e-tests |
Contributor
Author
|
/retest |
dvail
approved these changes
Jan 28, 2026
Contributor
dvail
left a comment
There was a problem hiding this comment.
Moving from a boolean value to an enum is definitely worthwhile to get this change in. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Undo changes in #18422
Align with changes in #18580
Last planned contribution from UI team
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with test instance from Yi Li as central.Manual testing
Manual testing for un-aligned
Visit /main/vulnerabilities/platform and select Image component as entity.
2 CVEs
Select Layer type as attribute and Application as value.
Page address query string has
s[Component%20From%20Base%20Image][0]=trueData request query string has
Component From Base Image:trueSearch filter label: Image component layer type Application
No results found
Select Layer type as attribute and Base image as value.
Page address query string has
s[Component%20From%20Base%20Image][0]=falseData request query string has
Component From Base Image:falseSearch filter label: Image component layer type Base image
No results found
Manual testing for re-aligned
Visit /main/vulnerabilities/platform and select Image component as entity.
2 CVEs
Select Layer type as attribute and Application as value.
Page address query string has
s[Component%20Layer%20Type][0]=APPLICATIONData request query string has
Component Layer Type:APPLICATIONSearch filter label: Image component layer type Application
2 CVEs
Select Layer type as attribute and Base image as value.
Page address query string has
s[Component%20Layer%20Type][0]=BASE_IMAGEData request query string has
Component Layer Type:BASE_IMAGESearch filter label: Image component layer type Base image
2 CVEs
Although 2 CVEs seems better than No results found why both values have same results surprises me.