Skip to content

ROX-31768: Fixes for global search#18784

Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31768-pf6-global-search
Jan 30, 2026
Merged

ROX-31768: Fixes for global search#18784
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31768-pf6-global-search

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Jan 30, 2026

See #17809 for more info on the PF migration.

Description

Fixes for the global search page:

  1. Fixes display of link colors/decoration in table
  2. Fixes display of color labels for (soon to be removed) legacy search bar
  3. Fixes z-index to prevent clipping of sticky table header

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Before:
image
image

After:
image
image

@dvail
Copy link
Contributor Author

dvail commented Jan 30, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/ROX-31768-pf6-global-search branch from 296cacd to b2f7e71 Compare January 30, 2026 18:38
@dvail dvail marked this pull request as ready for review January 30, 2026 18:42
@dvail dvail requested a review from a team as a code owner January 30, 2026 18:42
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (63e3116) to head (b2f7e71).
⚠️ Report is 1 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18784      +/-   ##
=====================================================
- Coverage              49.36%   49.34%   -0.03%     
=====================================================
  Files                   2659     2659              
  Lines                 200649   200572      -77     
=====================================================
- Hits                   99058    98974      -84     
- Misses                 94153    94158       +5     
- Partials                7438     7440       +2     
Flag Coverage Δ
go-unit-tests 49.34% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail merged commit 6677959 into dv/ROX-28622-pf-6 Jan 30, 2026
128 of 147 checks passed
@dvail dvail deleted the dv/ROX-31768-pf6-global-search branch January 30, 2026 20:54
dvail added a commit that referenced this pull request Feb 3, 2026
dvail added a commit that referenced this pull request Feb 6, 2026
dvail added a commit that referenced this pull request Feb 10, 2026
dvail added a commit that referenced this pull request Feb 11, 2026
dvail added a commit that referenced this pull request Feb 12, 2026
dvail added a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants