Skip to content

ROX-28622: Update UI to PatternFly 6#17809

Draft
dvail wants to merge 31 commits intomasterfrom
dv/ROX-28622-pf-6
Draft

ROX-28622: Update UI to PatternFly 6#17809
dvail wants to merge 31 commits intomasterfrom
dv/ROX-28622-pf-6

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Nov 13, 2025

Description

Update UI to PatternFly 6.

The core of this PR is an update to all PatternFly and Victory dependencies, followed by running PatternFly's automated CODEMOD tools. Few or zero manual changes have been made in this branch.

The plan

In order to make this upgrade as reviewable and pain-free as possible, the change will be broken down into many separate reviewable pull requests. Once all individual PRs are reviewed and approved, we will bug bash the changes as a whole and squash down into a single PR (this one!) so that the entirety of the change lands on master at once. This is necessary due to the nature of the change, which otherwise would introduce many UI bugs. Update as of Dec 1 after UI team sync: we are going to merge the branched PRs into this base PR as they are approved in order to reduce the burden of review (and CI) having many tens of changes open at once. The approvals for all of the individual PRs in combination with team testing of the change as a whole should serve as approval enough for this PR without having to re-read the changes again in aggregate.

I @dvail intend on using git-spice to stack all changes I make in a linear sequence of PRs. See #17809 (comment). Any other contributors can feel free to branch off where you feel it makes sense, but the further up the stack the better. I will rebase all of my changes frequently to avoid merge conflicts that spiral out of control and make it clear in the channel so that contributors can rebase their branches against the updated targets.

Contents

To see existing problems, markup structure changes, etc: (note that you will want to clear out ./build to prevent false positives)

npx @patternfly/pf-codemods@latest . --v6

Changes applied in this PR:

npm uninstall \
  @patternfly/react-core \
  @patternfly/react-icons \
  @patternfly/react-styles \
  @patternfly/react-table \
  @patternfly/react-topology \
  @patternfly/react-component-groups \
  @patternfly/react-user-feedback \
  @patternfly/react-charts

npm install \
  @patternfly/react-core@^6.4.0 \
  @patternfly/react-icons@^6.4.0 \
  @patternfly/react-styles@^6.4.0 \
  @patternfly/react-table@^6.4.0 \
  @patternfly/react-topology@^6.4.0 \
  @patternfly/react-component-groups@^6.4.0 \
  @patternfly/react-user-feedback@^6.2.0 \
  @patternfly/react-charts@^8.4.0

npx @patternfly/pf-codemods@latest . --v6 --fix

npm run lint:fix

npm install victory

npx @patternfly/class-name-updater . --v6 --fix

npx @patternfly/css-vars-updater . --v6 --fix

- Manually change pixel breakpoint equiv to rems

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

I validated that this change breaks every page in the application. Do not merge yet.

@dvail
Copy link
Contributor Author

dvail commented Nov 13, 2025

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Nov 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request #17809 has too many files changed.

The GitHub API will only let us fetch up to 300 changed files, and this pull request has 652.

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.52%. Comparing base (300a724) to head (de1e05a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #17809   +/-   ##
=======================================
  Coverage   49.52%   49.52%           
=======================================
  Files        2666     2666           
  Lines      201181   201181           
=======================================
+ Hits        99629    99632    +3     
+ Misses      94115    94113    -2     
+ Partials     7437     7436    -1     
Flag Coverage Δ
go-unit-tests 49.52% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ui do-not-merge/work-in-progress do-not-merge A change which is not meant to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants