Skip to content

fix(build): Revert ROX-32847: Enable ROX_BASE_IMAGE_DETECTION#18806

Merged
msugakov merged 1 commit intomasterfrom
misha/revert-pr-18708
Feb 3, 2026
Merged

fix(build): Revert ROX-32847: Enable ROX_BASE_IMAGE_DETECTION#18806
msugakov merged 1 commit intomasterfrom
misha/revert-pr-18708

Conversation

@msugakov
Copy link
Contributor

@msugakov msugakov commented Feb 3, 2026

Description

This reverts commit 637723a, PR #18708 to unblock master builds.

Obtained with just git revert HEAD.

Context: https://redhat-internal.slack.com/archives/C3W3U0RGW/p1770109359420009

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

If there would be no

roxvet: pkg/images/enricher/enricher_impl_test.go:355:33: cannot use emptyBaseImageGetter (value of type func(_ context.Context, _ []string) ([]*storage.BaseImageInfo, error)) as BaseImageGetter value in struct literal

errors during style-check (as compared to this), this is on the right path.

@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@msugakov msugakov marked this pull request as ready for review February 3, 2026 11:01
@msugakov msugakov requested review from a team as code owners February 3, 2026 11:01
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 3d3c967.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-23-g3d3c967c3a.

@msugakov msugakov enabled auto-merge (squash) February 3, 2026 11:34
@msugakov msugakov merged commit 5a0a465 into master Feb 3, 2026
105 of 107 checks passed
@msugakov msugakov deleted the misha/revert-pr-18708 branch February 3, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants