Skip to content

ROX-32847: Enable ROX_BASE_IMAGE_DETECTION#18708

Merged
daynewlee merged 2 commits intomasterfrom
ROX-32847-enable-ROX_BASE_IMAGE_DETECTION
Feb 3, 2026
Merged

ROX-32847: Enable ROX_BASE_IMAGE_DETECTION#18708
daynewlee merged 2 commits intomasterfrom
ROX-32847-enable-ROX_BASE_IMAGE_DETECTION

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Jan 27, 2026 •
edited
Loading

Description

Will merge later in day on Wednesday if no show stopper after async bug bash.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@pedrottimark pedrottimark requested a review from a team as a code owner January 27, 2026 21:37
@jvdm jvdm self-requested a review January 27, 2026 21:40
jvdm
jvdm approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@jvdm jvdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Scanner (Matching and Watching).

@jvdm jvdm requested review from a team and removed request for a team January 27, 2026 21:41
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 27, 2026 •
edited
Loading

Images are ready for the commit at d9c925b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-968-gd9c925bd05.

@pedrottimark pedrottimark force-pushed the ROX-32847-enable-ROX_BASE_IMAGE_DETECTION branch from f0f06c2 to 4b443b3 Compare January 28, 2026 01:38
@jvdm jvdm requested a review from a team as a code owner January 29, 2026 19:19
@jvdm jvdm force-pushed the ROX-32847-enable-ROX_BASE_IMAGE_DETECTION branch from 2c589c9 to 9e5a28a Compare January 29, 2026 19:20
@jvdm jvdm force-pushed the ROX-32847-enable-ROX_BASE_IMAGE_DETECTION branch from 9e5a28a to d9c925b Compare January 29, 2026 19:24
@codecov
Copy link

codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (a9a8ef4) to head (d9c925b).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #18708      +/-   ##
==========================================
- Coverage   49.34%   49.34%   -0.01%     
==========================================
  Files        2659     2659              
  Lines      200572   200572              
==========================================
- Hits        98979    98978       -1     
  Misses      94154    94154              
- Partials     7439     7440       +1
Flag Coverage Δ
go-unit-tests 49.34% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2026

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 9e5a28a link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 9e5a28a link false /test ocp-4-12-operator-e2e-tests
ci/prow/ocp-4-20-qa-e2e-tests 9e5a28a link false /test ocp-4-20-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jvdm
Copy link
Contributor

jvdm commented Jan 30, 2026

/retest-required

@jvdm
Copy link
Contributor

jvdm commented Jan 31, 2026

/test ci/prow/gke-upgrade-tests

@jvdm
Copy link
Contributor

jvdm commented Feb 2, 2026

/test gke-upgrade-tests

@daynewlee daynewlee merged commit 637723a into master Feb 3, 2026
96 checks passed
@daynewlee daynewlee deleted the ROX-32847-enable-ROX_BASE_IMAGE_DETECTION branch February 3, 2026 03:40
rhacs-bot pushed a commit that referenced this pull request Feb 3, 2026
@pedrottimark @jvdm @github-actions
ROX-32847: Enable ROX_BASE_IMAGE_DETECTION (#18708)
88dfadc 
Co-authored-by: Mark Pedrotti <mark@stackrox.com>
Co-authored-by: J. Victor Martins <jvdm@sdf.org>
(cherry picked from commit 637723a)
@rhacs-bot rhacs-bot mentioned this pull request Feb 3, 2026
Closed
msugakov added a commit that referenced this pull request Feb 3, 2026
@msugakov
Revert "ROX-32847: Enable ROX_BASE_IMAGE_DETECTION (#18708)"
3d3c967 
This reverts commit 637723a.
@msugakov msugakov mentioned this pull request Feb 3, 2026
Merged
4 tasks
@jvdm jvdm mentioned this pull request Feb 3, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvdm jvdm jvdm approved these changes

@c-du c-du c-du approved these changes

Assignees

No one assigned

Labels

backport release-4.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pedrottimark @rhacs-bot @jvdm @c-du @daynewlee