Skip to content

ROX-31785: Fix clusters page styles#18902

Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31785-fix-clusters-page
Feb 6, 2026
Merged

ROX-31785: Fix clusters page styles#18902
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31785-fix-clusters-page

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 6, 2026

Description

More of the same for the clusters page and subpages.

The only item of note: TabNav is no longer used and instead we just use PF <Tabs> directly. This, and the TabNavHeader component will eventually be fully removed and we can delete them when there are no more uses.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

image image image image image image image

@dvail
Copy link
Contributor Author

dvail commented Feb 6, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.46%. Comparing base (eb11e65) to head (1ffdf34).
⚠️ Report is 1 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18902      +/-   ##
=====================================================
- Coverage              49.47%   49.46%   -0.01%     
=====================================================
  Files                   2661     2661              
  Lines                 200744   200744              
=====================================================
- Hits                   99311    99300      -11     
- Misses                 94013    94023      +10     
- Partials                7420     7421       +1     
Flag Coverage Δ
go-unit-tests 49.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail force-pushed the dv/ROX-31785-fix-clusters-page branch 2 times, most recently from f5756bc to 798e35d Compare February 6, 2026 17:50
@dvail dvail force-pushed the dv/ROX-31785-fix-clusters-page branch from 798e35d to 1ffdf34 Compare February 6, 2026 18:34
@dvail dvail marked this pull request as ready for review February 6, 2026 18:39
@dvail dvail requested a review from a team as a code owner February 6, 2026 18:39
@dvail dvail merged commit 8951f3d into dv/ROX-28622-pf-6 Feb 6, 2026
139 of 160 checks passed
@dvail dvail deleted the dv/ROX-31785-fix-clusters-page branch February 6, 2026 21:46
dvail added a commit that referenced this pull request Feb 10, 2026
dvail added a commit that referenced this pull request Feb 11, 2026
dvail added a commit that referenced this pull request Feb 12, 2026
dvail added a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants