Skip to content

ROX-31788: Fix PF6 migration issues for Integrations#18981

Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31788-fixes-for-integrations
Feb 11, 2026
Merged

ROX-31788: Fix PF6 migration issues for Integrations#18981
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31788-fixes-for-integrations

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 11, 2026 •
edited
Loading

Description

More of the same, mostly, for the integrations page.

One item of note: https://github.com/stackrox/stackrox/pull/18981/changes?w=1#diff-5ad0a63c60bb34254587b55ff2b42aba64f81339908e9a4aa6382d8e8424dc70

Wrapping a selectable/clickable card with an <a> element causes some a11y issues due to nested clickable items, some e2e test issues due to the same, and display issues after the upgrade to PatternFly 6. Instead, the following changes were applied:

  • isSelectable => isClickable
  • <Link> wrapper replaced with selectable action and click event for navigation
  • unfortunate utility class addition to handle awkwardness of <Badge> component as a header action

It may be worthwhile to revisit the design and structure of the tiles entirely at some point in the future, but a full rework was outside of the scope of this migration.

Bonus! Apparently the structure changes above have fixed the gap issue on Firefox! https://issues.redhat.com/browse/ROX-32920

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

image image image image
  • Manual inspection of the variety of integration forms

@dvail
Copy link
Contributor Author

dvail commented Feb 11, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail marked this pull request as ready for review February 11, 2026 17:28
@dvail dvail requested a review from a team as a code owner February 11, 2026 17:28
@codecov
Copy link

codecov bot commented Feb 11, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.50%. Comparing base (29da946) to head (c9f760f).
⚠️ Report is 3 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files 
@@                Coverage Diff                 @@
##           dv/ROX-28622-pf-6   #18981   +/-   ##
==================================================
  Coverage              49.50%   49.50%           
==================================================
  Files                   2662     2662           
  Lines                 200985   200985           
==================================================
+ Hits                   99489    99499   +10     
+ Misses                 94072    94065    -7     
+ Partials                7424     7421    -3
Flag Coverage Δ
go-unit-tests 49.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail mentioned this pull request Feb 11, 2026
Merged
9 tasks
@pedrottimark
Copy link
Contributor

pedrottimark commented Feb 11, 2026

Link wrapper replaced with selectable action and click event for navigation

It may be worthwhile to revisit the design and structure of the tiles entirely

Agree, because link is more accessible, we can study PatternFly design guidelines more carefully and simplify if needed.

@dvail dvail merged commit 84e6c03 into dv/ROX-28622-pf-6 Feb 11, 2026
80 of 93 checks passed
@dvail dvail deleted the dv/ROX-31788-fixes-for-integrations branch February 11, 2026 18:42
dvail added a commit that referenced this pull request Feb 11, 2026
@dvail
ROX-31788: Fix PF6 migration issues for Integrations (#18981)
606ceb6
dvail added a commit that referenced this pull request Feb 12, 2026
@dvail
ROX-31788: Fix PF6 migration issues for Integrations (#18981)
abf2ae6
dvail added a commit that referenced this pull request Feb 13, 2026
@dvail
ROX-31788: Fix PF6 migration issues for Integrations (#18981)
eebfadf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrottimark pedrottimark pedrottimark approved these changes

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvail @pedrottimark