Skip to content

ROX-31790: PF6 fixes for access control#18987

Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31790-pf6-fixes-access-control
Feb 12, 2026
Merged

ROX-31790: PF6 fixes for access control#18987
dvail merged 1 commit intodv/ROX-28622-pf-6from
dv/ROX-31790-pf6-fixes-access-control

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 11, 2026

Description

More of the same, for access control. A bit larger of a diff due to the more in-depth layouts needed for form sub components. As always, hide whitespace.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

image image image image image image image image

@dvail
Copy link
Contributor Author

dvail commented Feb 11, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.53%. Comparing base (40beaee) to head (95b1e65).
⚠️ Report is 1 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #18987      +/-   ##
=====================================================
- Coverage              49.53%   49.53%   -0.01%     
=====================================================
  Files                   2666     2666              
  Lines                 201134   201134              
=====================================================
- Hits                   99628    99624       -4     
- Misses                 94070    94072       +2     
- Partials                7436     7438       +2     
Flag Coverage Δ
go-unit-tests 49.53% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail marked this pull request as ready for review February 12, 2026 17:53
@dvail dvail requested a review from a team as a code owner February 12, 2026 17:53
Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Access Control was first feature in PatternFly after acquisition, and it shows.

@dvail dvail merged commit e6ba219 into dv/ROX-28622-pf-6 Feb 12, 2026
80 of 91 checks passed
@dvail dvail deleted the dv/ROX-31790-pf6-fixes-access-control branch February 12, 2026 19:11
dvail added a commit that referenced this pull request Feb 12, 2026
dvail added a commit that referenced this pull request Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants