ROX-33304: Fix prerequisites to upgrade TypeScript 6.0#19161
Merged
pedrottimark merged 1 commit intomasterfrom Feb 24, 2026
Merged
ROX-33304: Fix prerequisites to upgrade TypeScript 6.0#19161pedrottimark merged 1 commit intomasterfrom
pedrottimark merged 1 commit intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at f01e7b6. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19161 +/- ##
========================================
Coverage 49.52% 49.52%
========================================
Files 2670 2672 +2
Lines 201549 201667 +118
========================================
+ Hits 99809 99875 +66
- Misses 94289 94335 +46
- Partials 7451 7457 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test gke-ui-e2e-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Objective: Because breaking changes for TypeScript 6.0 are compatible with TypeScript 5.9 and especially because no compile errors, fix prerequisites now so upgrade contribution in a few weeks will be easy.
https://devblogs.microsoft.com/typescript/announcing-typescript-6-0-beta/
Configuration errors
Configuration changes
https://devblogs.microsoft.com/typescript/announcing-typescript-6-0-beta/#breaking-changes-and-deprecations-in-typescript-6.0
Delete deprecated
baseUrlproperty.Add
pathsproperty as declarative replacement for whatbaseUrlhad done.Replace
moduleandmoduleResolutionproperties to fix 36 occurrences of TS2307 error for dynamicimportpaths in Body.tsx file.Specifically,
"moduleResolution": "bundler"which is accurate.Bonus
"module": "es2020"is specific to what this project assumes.Add
rootDirproperty.Although TypeScript does not output files in this project, if I understand correctly, it might waste time inferring.
Edit
includeproperty to simplify the path.Follow examples in documentation that I read to understand other changes.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run startin ui/apps/platform folder with staging demo as central.npm buildin ui/apps/platform folder.