ROX-33387: Add rootDir in cypress tsconfig file#19220
Merged
pedrottimark merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
Contributor
|
Images are ready for the commit at a3c37c4. To use with deploy scripts, first |
bradr5
approved these changes
Feb 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19220 +/- ##
==========================================
- Coverage 49.56% 49.56% -0.01%
==========================================
Files 2675 2675
Lines 201838 201838
==========================================
- Hits 100038 100035 -3
- Misses 94343 94345 +2
- Partials 7457 7458 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
File '/stackrox/stackrox/ui/apps/platform/cypress/constants/GeneralPage.js' is not under 'rootDir' '/Users/mark/go/src/github.com/stackrox/stackrox/ui/apps/platform/src'. 'rootDir' is expected to contain all source files.
The file is in the program because:
Matched by include pattern './**/*.js' in '/Users/mark/go/src/github.com/stackrox/stackrox/ui/apps/platform/cypress/tsconfig.json'
Analysis
https://devblogs.microsoft.com/typescript/announcing-typescript-6-0-beta/#rootdir-now-defaults-to-.
Advice that I followed in #19161
That is good as far as it goes, except cypress folder has tsconfig.json file that inherits from the parent configuration file:
Therefore it inherits
"rootDir": "./src"property which does not include the files in cypress folder.Futhermore its
includesproperty includes (pardon pun) files outside the cypress folder:"../node_modules/cypress", "../cypress.d.ts"Solution
Add
"rootDir": ".."property to cypress tsconfig.json file.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.