ROX-31787: Fixes for PF6 migration in collections#19163
Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from Feb 24, 2026
Merged
ROX-31787: Fixes for PF6 migration in collections#19163dvail merged 1 commit intodv/ROX-28622-pf-6from
dvail merged 1 commit intodv/ROX-28622-pf-6from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
dvail
commented
Feb 24, 2026
ui/apps/platform/src/Containers/Collections/RuleSelector/RuleSelector.css
Show resolved
Hide resolved
8cea637 to
668c0f5
Compare
dvail
commented
Feb 24, 2026
pedrottimark
approved these changes
Feb 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #19163 +/- ##
=====================================================
- Coverage 49.52% 49.52% -0.01%
=====================================================
Files 2666 2666
Lines 201181 201181
=====================================================
- Hits 99632 99625 -7
- Misses 94113 94120 +7
Partials 7436 7436
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Collection page is one of the earlier pages to use PatternFly, and contains a lot of classname props and custom CSS, unfortunately.
Since this section is deprecated and will be removed in a future version, I did not put much emphasis on fixing these issues now and aimed solely to fix the page layout to keep it roughly consistent with what we had previously.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Via the Collections page:
Read only:
Via the reporting modal:
