Skip to content

ROX-33389: Fix misc tsc errors in PF6 migration#19221

Open
dvail wants to merge 1 commit intodv/ROX-28622-pf-6from
dv/ROX-33389-fix-remaining-tsc-errors
Open

ROX-33389: Fix misc tsc errors in PF6 migration#19221
dvail wants to merge 1 commit intodv/ROX-28622-pf-6from
dv/ROX-33389-fix-remaining-tsc-errors

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 26, 2026 •
edited
Loading

Description

As titled, the few that slipped through the cracks. Mostly due to work happening in parallel with this branch.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Type level changes only, with the exception of the Base images modal
image

@dvail
Copy link
Contributor Author

dvail commented Feb 26, 2026 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 26, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

dvail
dvail commented Feb 26, 2026
View reviewed changes
ui/apps/platform/src/Containers/Violations/Details/ViolationDetails.tsx
Copy link
Contributor Author

@dvail dvail Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantic merge conflict - fileAccessViolation is no longer passed here.

@dvail dvail changed the base branch from dv/ROX-33388-replace-labelicon-prop to dv/ROX-28622-pf-6 February 26, 2026 21:55
@dvail dvail force-pushed the dv/ROX-33389-fix-remaining-tsc-errors branch from ecf159e to a44dea9 Compare February 26, 2026 21:55
@dvail dvail marked this pull request as ready for review February 26, 2026 21:56
@dvail dvail requested a review from a team as a code owner February 26, 2026 21:56
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 26, 2026

Images are ready for the commit at a44dea9.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-127-gecf159ee6f.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dv/ROX-28622-pf-6@063e33c). Learn more about missing BASE report.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##             dv/ROX-28622-pf-6   #19221   +/-   ##
====================================================
  Coverage                     ?   49.52%           
====================================================
  Files                        ?     2666           
  Lines                        ?   201181           
  Branches                     ?        0           
====================================================
  Hits                         ?    99625           
  Misses                       ?    94119           
  Partials                     ?     7437
Flag Coverage Δ
go-unit-tests 49.52% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvail @rhacs-bot