Skip to content

ROX-31794: Fix remaining pf6 codemod errors#19235

Merged
dvail merged 5 commits intodv/ROX-28622-pf-6from
dv/ROX-31794-pf-codemod-remaining-errors
Feb 27, 2026
Merged

ROX-31794: Fix remaining pf6 codemod errors#19235
dvail merged 5 commits intodv/ROX-28622-pf-6from
dv/ROX-31794-pf-codemod-remaining-errors

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Feb 27, 2026

Description

Fix remaining pf6 codemod errors.

  1. Move button icons to icon prop
  2. Update deprecated CSS token to semantic token
  3. Fix IntegrationTile codemod and console error, by accepting this is an off-road choice and just adding inline style instead of trying to force this into the PatternFly API
  4. Fix prettier lint errors after most recent rebase

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Verify search bar button rendering:
image

Verify integration tiles:
image
image

@dvail
Copy link
Contributor Author

dvail commented Feb 27, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Feb 27, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/ROX-31794-pf-codemod-remaining-errors branch from 7bca829 to 8d8bd1f Compare February 27, 2026 16:34
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 27, 2026

Images are ready for the commit at 43a25a4.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-238-g43a25a4b86.

@dvail dvail marked this pull request as ready for review February 27, 2026 16:45
@dvail dvail requested a review from a team as a code owner February 27, 2026 16:45
@dvail dvail force-pushed the dv/ROX-31794-pf-codemod-remaining-errors branch from 8d8bd1f to 41a000d Compare February 27, 2026 16:59
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.55%. Comparing base (ba3f8d9) to head (43a25a4).
⚠️ Report is 1 commits behind head on dv/ROX-28622-pf-6.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           dv/ROX-28622-pf-6   #19235      +/-   ##
=====================================================
- Coverage              49.55%   49.55%   -0.01%     
=====================================================
  Files                   2675     2675              
  Lines                 201838   201838              
=====================================================
- Hits                  100029   100025       -4     
- Misses                 94349    94354       +5     
+ Partials                7460     7459       -1     
Flag Coverage Δ
go-unit-tests 49.55% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail force-pushed the dv/ROX-31794-pf-codemod-remaining-errors branch from 41a000d to 43a25a4 Compare February 27, 2026 18:38
@dvail dvail merged commit 5c8ffeb into dv/ROX-28622-pf-6 Feb 27, 2026
125 of 153 checks passed
@dvail dvail deleted the dv/ROX-31794-pf-codemod-remaining-errors branch February 27, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants