ROX-31764: Clean up remaining pf-v5 overrides#19266
Merged
dvail merged 15 commits intodv/ROX-28622-pf-6from Mar 3, 2026
Merged
ROX-31764: Clean up remaining pf-v5 overrides#19266dvail merged 15 commits intodv/ROX-28622-pf-6from
dvail merged 15 commits intodv/ROX-28622-pf-6from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
3f0b52d to
9d6cda1
Compare
Contributor
|
Images are ready for the commit at 9d6cda1. To use with deploy scripts, first |
pedrottimark
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clean up remaining instances of
pf-v5in the codebase, excluding test selectors. One commit per change. Will list individual changes in testing section below.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Fix dashboard maxWidth for items
Revert Prettier style changes...
[ no picture ] - honestly not sure where this came from...
Fix dashboard namespace dropdown sticky headers (note - broken on staging)
Use default spacing for Syslog CEF toggle buttons (removes opinionated non-PatternFly default)
Use default Orchestrator components toggle colors
Remove unneccessary horizontal dropdown nav styles
Remove unneeded padding style - no expanded content. Boilerplate from #3323? It is possible that we never had expanded content in this section, or that the expanded content was removed long ago.
Remove nested expanded sections in NG to prevent improper child expand display. In PatternFly 6, expandable sections cannot be nested, otherwise the child section will display at the full expanded size with no visible content.
"Fix" NG simulator border color. (The NG simulator has bigger problems, but no reason to not do this I suppose)
Fix various table border overrides
[no picture]
Fix MITRE TreeView and unmigrated pf5 class. (This section uses internal PF class names to implement a pseudo-tree view component. It required a change in the DOM nesting to return to working order.)
Remove unneeded policy card header wrapping
Remove overrides for
pf-m-smallerclass. Uses<Button size="sm">to get almost identical results, and removes internal PF cusomtization.Remove remaining pf-v5 vars (commented out)
[no picture] These were only in comments!