Skip to content

fix(ui): Many very small fixes for PF6 upgrade#19337

Merged
dvail merged 21 commits intodv/ROX-28622-pf-6from
dv/pf6-migration-qol-fixes
Mar 9, 2026
Merged

fix(ui): Many very small fixes for PF6 upgrade#19337
dvail merged 21 commits intodv/ROX-28622-pf-6from
dv/pf6-migration-qol-fixes

Conversation

@dvail
Copy link
Contributor

@dvail dvail commented Mar 9, 2026

Description

As titled, very small changes to clean up minor visual issues from the bug bash. Each commit is one issue from the doc https://docs.google.com/document/d/1ohSgk5RpqJJFEE0wZjnq82GU72V9ZLHkmx6f6wDcmq8/edit?tab=t.0

Recommended to Hide whitespace

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

Manual visual testing. I will spare this PR from dozens of screenshots...

@dvail
Copy link
Contributor Author

dvail commented Mar 9, 2026

This change is part of the following stack:

Change managed by git-spice.

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dvail dvail force-pushed the dv/pf6-migration-qol-fixes branch from 5bc41e4 to 4d10282 Compare March 9, 2026 16:58
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 9, 2026

Images are ready for the commit at 4d10282.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-261-g4d1028270a.

@dvail dvail marked this pull request as ready for review March 9, 2026 18:06
@dvail dvail requested a review from a team as a code owner March 9, 2026 18:06
@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (dv/ROX-28622-pf-6@f142343). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             dv/ROX-28622-pf-6   #19337   +/-   ##
====================================================
  Coverage                     ?   49.56%           
====================================================
  Files                        ?     2675           
  Lines                        ?   201838           
  Branches                     ?        0           
====================================================
  Hits                         ?   100036           
  Misses                       ?    94345           
  Partials                     ?     7457           
Flag Coverage Δ
go-unit-tests 49.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvail dvail merged commit b278884 into dv/ROX-28622-pf-6 Mar 9, 2026
146 of 147 checks passed
@dvail dvail deleted the dv/pf6-migration-qol-fixes branch March 9, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants