fix(ui): Re-add dark theme support#19385
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
dfc9132 to
92430aa
Compare
|
Images are ready for the commit at 5f84c5d. To use with deploy scripts, first |
92430aa to
874b803
Compare
874b803 to
2e7d0e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #19385 +/- ##
=====================================================
- Coverage 49.65% 49.65% -0.01%
=====================================================
Files 2698 2698
Lines 203066 203066
=====================================================
- Hits 100824 100823 -1
- Misses 94722 94724 +2
+ Partials 7520 7519 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sachaudh
left a comment
There was a problem hiding this comment.
LGTM. A couple of minor suggestions and questions.
Description
PatternFly 6 with dark theme support.
The main changes to support this:
"@patternfly/patternfly": "^6.4.0"as a dependency to import chart css?reactsuffix to import as a Component instead of a URI to an SVG file. This allows us to style SVGs with CSS in a maintainable way.class="text"to dark, textual pieces of these SVG files so that they can respond to dark theming (see images below). This class will change the fill color to white when a dark theme is applied.textclass to textual elements in integration logos in order to avoid black text on dark backgroundsUser-facing documentation
Testing and quality
Automated testing
How I validated my change
Manual verification of styles.
