Conversation
|
Skipping CI for Draft Pull Request. |
The explicit 5-value Entity Type array listed all proto enum values,
making it functionally identical to omitting the filter. Returning {}
is simpler, avoids unnecessary query complexity, and prevents silent
exclusion of future entity types added to the proto.
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Images are ready for the commit at af00682. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19399 +/- ##
=======================================
Coverage 49.68% 49.68%
=======================================
Files 2700 2700
Lines 203278 203278
=======================================
+ Hits 100999 101004 +5
+ Misses 94753 94749 -4
+ Partials 7526 7525 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/test gke-nongroovy-e2e-tests |
pedrottimark
left a comment
There was a problem hiding this comment.
Similar question has come to my mind in edge case when customer selects all options for a search filter on checkbox select.
Description
Jira: ROX-33429
Follow-up from PR #19223 review feedback.
The
getFilteredWorkflowViewSearchFilterfunction returned all 5EntityTypeenum values for the "Full view" case. Since listing every value is equivalent to no filter, this replaces it with{}(empty object). This is simpler, avoids unnecessary query complexity, and prevents silent exclusion of future entity types added to the proto.User-facing documentation
Testing and quality
Automated testing
No tests added -- one-line logic change with no new behavior to test.
How I validated my change