feat(clusters): allow operator install method on non-OpenShift platforms#19446
Draft
feat(clusters): allow operator install method on non-OpenShift platforms#19446
Conversation
ROX-33119: Remove platform gating that restricted the Operator installation method to OpenShift only. Update instruction text in both Init Bundles and CRS flows to be platform-neutral, with qualified sub-bullets for OpenShift vs other platforms and kubectl as an alternative to oc. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
…pace Simplify onChangePlatform to only set the platform field instead of resetting installation to Operator on every platform switch, which silently overrode the user's selection. Also fix ClipboardCopy in CRS operator instructions where line wrapping caused whitespace in the copied command text. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
|
Skipping CI for Draft Pull Request. |
Remove Record<string, string> annotations that widened as const types, so InstallationKey resolves to 'Operator' | 'Helm' and PlatformKey to 'OpenShift' | 'EKS' | 'AKS' | 'GKE'. Add oneOf validators to the yup schema for compile-time and runtime safety. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Add missing article in heading ("using the Operator installation
method"), replace awkward colon with comma in OpenShift web console
bullet, remove redundant clause, and fix plural "secrets" to
singular "secret" in CRS apply step.
Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Rewrite "In the cluster that you are securing, you have installed the RHACS Operator" to lead with the action for clarity. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Remove "by" from "by using", replace redundant "YAML file for the init bundle/cluster registration secret" with "its YAML file", shorten "Perform one of the following tasks to apply..." to "Apply it using one of the following methods:", and simplify the final install step. Signed-off-by: Saif Chaudhry <schaudhr@redhat.com>
Contributor
|
Images are ready for the commit at edf5a64. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19446 +/- ##
==========================================
- Coverage 49.56% 49.56% -0.01%
==========================================
Files 2711 2711
Lines 204849 204849
==========================================
- Hits 101528 101527 -1
+ Misses 95741 95740 -1
- Partials 7580 7582 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROX-33119: Remove platform gating that restricted the Operator installation method to OpenShift only. Update instruction text in both Init Bundles and CRS flows to be platform-neutral, with qualified sub-bullets for OpenShift vs other platforms and kubectl as an alternative to oc.
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!