-
Notifications
You must be signed in to change notification settings - Fork 170
ROX-33119: Allow operator install method on non-OpenShift platforms #19446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sachaudh
wants to merge
10
commits into
master
Choose a base branch
from
ROX-33119/operator-instructions-non-openshift
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+92
−68
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e744bb2
feat(clusters): allow operator install method on non-OpenShift platforms
sachaudh 01b1c35
fix(clusters): simplify onChangePlatform and fix ClipboardCopy whites…
sachaudh 550afd8
refactor(clusters): narrow InstallationKey and PlatformKey types
sachaudh aec708c
fix(clusters): correct grammar in operator instruction text
sachaudh d95da09
fix(clusters): simplify operator prerequisite wording
sachaudh edf5a64
fix(clusters): tighten wordy instruction text
sachaudh 9b6e83e
fix(clusters): use HTML entities for ClipboardCopy angle brackets
sachaudh 22477e6
refactor(clusters): derive oneOf values from option objects
sachaudh a2e72fa
fix(clusters): add type annotation to onChangePlatform parameter
sachaudh 3f45cd2
fix(clusters): remove trailing whitespace in instruction text
sachaudh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@porridge, I changed this from the suggested: "In the cluster that you are securing, you have installed the RHACS Operator". This puts the action first and tacks on the location as a simple prepositional phrase at the end, which feels more direct.
I see that we use fronted prepositional phrases with a relative clause in a few other areas, too. Your suggestion probably followed the same pattern, but I wonder if we should keep this to make it clearer.
@mansursyed @zhenpesky, this might be relevant for you both, too.