ROX-33574: Don't forget to configure scanner pull secrets#19451
ROX-33574: Don't forget to configure scanner pull secrets#19451rhacs-bot wants to merge 1 commit intorelease-4.9from
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 28322140 | Triggered | Username Password | 2ae20a4 | pkg/helm/charts/tests/securedclusterservices/testdata/helmtest/image-pull-secrets.test.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Images are ready for the commit at 2ae20a4. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-4.9 #19451 +/- ##
===============================================
- Coverage 48.87% 48.87% -0.01%
===============================================
Files 2719 2719
Lines 202915 202915
===============================================
- Hits 99181 99174 -7
- Misses 95965 95972 +7
Partials 7769 7769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/konflux-retest main-on-push |
|
/konflux-retest operator-bundle-on-push |
|
/retest |
|
/konflux-retest main-on-push |
|
/konflux-retest operator-bundle-on-push |
|
@rhacs-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Backport 1331603 from #19383.