ROX-33205: Upgrade vitest 4.1.0#19462
Merged
pedrottimark merged 2 commits intomasterfrom Mar 18, 2026
Merged
Conversation
Contributor
|
Images are ready for the commit at b105f44. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19462 +/- ##
=======================================
Coverage 49.32% 49.32%
=======================================
Files 2722 2722
Lines 205173 205171 -2
=======================================
+ Hits 101199 101204 +5
+ Misses 96442 96437 -5
+ Partials 7532 7530 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/test gke-upgrade-tests |
dvail
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://vitest.dev/blog/vitest-4
https://vitest.dev/guide/migration
https://vitest.dev/guide/migration.html#simplified-exclude
This means that Vitest no longer excludes:
distandcypressfolders.idea,.cache,.output,.tempfoldersrollup.config.js,prettier.config.js,ava.config.jsand so oneslint-plugin-vitest
https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/no-conditional-expect.md
That is, if conditional is incorrect, I guess.
Add ESLint disable comment, because false positive does not seem like a risk.
plugin-react
TL;DR Upgrade to 5.2.0 because it supports, but does not require, vite 8.
https://github.com/vitejs/vite-plugin-react/releases/tag/plugin-react%406.0.0
https://github.com/vitejs/vite-plugin-react/releases/tag/plugin-react%405.2.0
https://github.com/vitejs/vite-plugin-react/releases/tag/plugin-react%405.0.0
Procedure
npm outdatedin ui/apps/platform folder.Visit npmjs.com for outdated vitest and related dependencies
@testing-library/…@vitest/…Click Repository link, and then read either of the following:
User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.npm run testin ui/apps/platform folder.Same counts before and after upgrade: