Skip to content

ROX-33648: Upgrade vite 8.0.0#19492

Open
pedrottimark wants to merge 1 commit intomasterfrom
ROX-33648-devDependencies-vite-8.0.0
Open

ROX-33648: Upgrade vite 8.0.0#19492
pedrottimark wants to merge 1 commit intomasterfrom
ROX-33648-devDependencies-vite-8.0.0

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Mar 18, 2026 •
edited
Loading

Description

Aha, some related deDependencies do not yet include 8 in their peer dependencies.

I will replace with upgrade to vite 7 instead.

https://vite.dev/blog/announcing-vite8

When Vite first launched, we made a pragmatic bet on two bundlers: esbuild for speed during development, and Rollup for optimized production builds. That bet served us well for years. We're very grateful to the Rollup and esbuild maintainers. Vite wouldn't have succeeded without them. Today, it resolves into one: Vite 8 ships with Rolldown as its single, unified, Rust-based bundler, delivering up to 10-30x faster builds while maintaining full plugin compatibility. This is the most significant architectural change since Vite 2.

Vite 8 requires Node.js 20.19+, 22.12+, the same requirements as Vite 7. These ranges ensure Node.js supports require(esm) without a flag, allowing Vite to be distributed as ESM only.

https://vite.dev/guide/migration#migration-from-v7

To reduce risk, I deferred the following upgrade that I mentioned in #19462

https://github.com/vitejs/vite-plugin-react/releases/tag/plugin-react%406.0.0

Vite 8+ can handle React Refresh Transform by Oxc and doesn't need Babel for it. With that, there are no transform applied that requires Babel. To reduce the installation size of this plugin, babel is no longer a dependency of this plugin and the related features are removed.

Vite 7 and below are no longer supported. If you are using Vite 7, please upgrade to Vite 8.

Change

  1. Edited stub test to remove 2 warnings in policyCriteriaValidators.test.ts file.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.
  3. npm run test in ui/apps/platform folder.
  4. npm run start in ui/apps/platform folder with staging demo as central.

@pedrottimark pedrottimark requested review from a team as code owners March 18, 2026 20:46
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.26%. Comparing base (1a5dfd0) to head (e7fcbeb).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #19492      +/-   ##
==========================================
- Coverage   49.27%   49.26%   -0.01%     
==========================================
  Files        2726     2726              
  Lines      205626   205626              
==========================================
- Hits       101313   101308       -5     
- Misses      96778    96781       +3     
- Partials     7535     7537       +2
Flag Coverage Δ
go-unit-tests 49.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dvail
dvail reviewed Mar 18, 2026
View reviewed changes
Copy link
Contributor

@dvail dvail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to try this out.

We should add the konflux-build label to this PR too to make sure everything looks good in that environment as well.

It also might make sense to take a look at ui/apps/platform/scripts/check-optional-dependency-versions.js. I'm not sure how much of that (if any) will remain relevant.

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-ui-e2e-tests e7fcbeb link true /test gke-ui-e2e-tests
ci/prow/gke-nongroovy-e2e-tests e7fcbeb link true /test gke-nongroovy-e2e-tests
ci/prow/gke-upgrade-tests e7fcbeb link false /test gke-upgrade-tests
ci/prow/ocp-4-12-nongroovy-e2e-tests e7fcbeb link false /test ocp-4-12-nongroovy-e2e-tests
ci/prow/ocp-4-20-ui-e2e-tests e7fcbeb link false /test ocp-4-20-ui-e2e-tests
ci/prow/ocp-4-20-nongroovy-e2e-tests e7fcbeb link false /test ocp-4-20-nongroovy-e2e-tests
ci/prow/ocp-4-21-nongroovy-e2e-tests e7fcbeb link false /test ocp-4-21-nongroovy-e2e-tests
ci/prow/ocp-4-21-ui-e2e-tests e7fcbeb link false /test ocp-4-21-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvail dvail dvail left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedrottimark @dvail