Skip to content

ROX-33635: Delete ROX_BASE_IMAGE_DETECTION in ui#19467

Open
pedrottimark wants to merge 2 commits intomasterfrom
ROX-33635-delete-ROX_BASE_IMAGE_DETECTION-ui
Open

ROX-33635: Delete ROX_BASE_IMAGE_DETECTION in ui#19467
pedrottimark wants to merge 2 commits intomasterfrom
ROX-33635-delete-ROX_BASE_IMAGE_DETECTION-ui

Conversation

@pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented Mar 17, 2026 •
edited
Loading

Description

Thank you, J. Victor for confirmation:

I doesn't depend on V4.

Review: Hide space because indentation changes.

Feature flag was enabled for 4.10 release on 2026-02-03 in #18809

https://github.com/stackrox/stackrox/tree/master/ui/apps/platform#delete-a-feature-flag-from-frontend-code

Analysis

Find in Files ROX_BASE_IMAGE_DETECTION has 10 results in 9 files.

Solution

Some conditional logic depended only on 'ROX_BASE_IMAGE_DETECTION' but also needed 'ROX_SCANNER_V4' therefore I replaced instead of deleted.

User-facing documentation

  • CHANGELOG.md update is not needed
  • documentation PR is not needed

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • edited unit tests
  • edited e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  1. npm run tsc in ui/apps/platform folder.
  2. npm run lint:fast-dev in ui/apps/platform folder.
  3. npm run start in ui/apps/platform folder with staging demo as central.

Manual testing

  1. Visit /main/vulnerabilities/inactive-images click Images toggle, filter Image component Layer type Base image and click an image link, and then expand Base image assessment

    See gray label that does not have link
    Base_image_assessment

    Expand vulnerability to see Layer type column in component table
    Layer_type

  2. Visit /main/base-images
    Base_Images

@pedrottimark pedrottimark requested a review from a team as a code owner March 17, 2026 19:59
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 17, 2026 •
edited
Loading

Images are ready for the commit at 40ad06c.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-356-g40ad06c66c.

@codecov
Copy link

codecov bot commented Mar 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.33%. Comparing base (b3b88ab) to head (40ad06c).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19467   +/-   ##
=======================================
  Coverage   49.32%   49.33%           
=======================================
  Files        2722     2722           
  Lines      205163   205163           
=======================================
+ Hits       101202   101210    +8     
+ Misses      96429    96423    -6     
+ Partials     7532     7530    -2
Flag Coverage Δ
go-unit-tests 49.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pedrottimark
Copy link
Contributor Author

pedrottimark commented Mar 17, 2026

/test ocp-4-20-ui-e2e-tests
/test ocp-4-21-ui-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Mar 18, 2026

@pedrottimark: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-20-ui-e2e-tests 40ad06c link false /test ocp-4-20-ui-e2e-tests
ci/prow/ocp-4-21-ui-e2e-tests 40ad06c link false /test ocp-4-21-ui-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pedrottimark @rhacs-bot