Skip to content

ROX-32847: Enable ROX_BASE_IMAGE_DETECTION#18809

Merged
daynewlee merged 3 commits intomasterfrom
yli3/baseImageFeatureFlag
Feb 3, 2026
Merged

ROX-32847: Enable ROX_BASE_IMAGE_DETECTION#18809
daynewlee merged 3 commits intomasterfrom
yli3/baseImageFeatureFlag

Conversation

@daynewlee
Copy link
Contributor

@daynewlee daynewlee commented Feb 3, 2026 •
edited by jvdm
Loading

Description

The original PR to enable this failed due to compilation issues: #18708

This is a second attempt that fixes the problem. func baseImageGetter(_ context.Context, _ []string) ([]*storage.BaseImage, error) was returning BaseImage instead of BaseImageInfo.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@daynewlee daynewlee requested review from a team as code owners February 3, 2026 14:10
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Feb 3, 2026 •
edited
Loading

Images are ready for the commit at 1afe4ea.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-26-g1afe4ea80b.

@daynewlee daynewlee added backport PR to backport changes from master to release branch backport release-4.10 labels Feb 3, 2026
@daynewlee
Copy link
Contributor Author

daynewlee commented Feb 3, 2026

/test ocp-4-12-operator-e2e-tests

@codecov
Copy link

codecov bot commented Feb 3, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.39%. Comparing base (5a0a465) to head (1afe4ea).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #18809   +/-   ##
=======================================
  Coverage   49.38%   49.39%           
=======================================
  Files        2659     2659           
  Lines      200734   200734           
=======================================
+ Hits        99139    99148    +9     
+ Misses      94156    94149    -7     
+ Partials     7439     7437    -2
Flag Coverage Δ
go-unit-tests 49.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daynewlee daynewlee requested a review from alwayshooin February 3, 2026 16:56
@openshift-ci
Copy link

openshift-ci bot commented Feb 3, 2026

@daynewlee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 1afe4ea link false /test ocp-4-12-qa-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jvdm
jvdm approved these changes Feb 3, 2026
View reviewed changes
Copy link
Contributor

@jvdm jvdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daynewlee daynewlee merged commit 230a72b into master Feb 3, 2026
101 of 102 checks passed
@daynewlee daynewlee deleted the yli3/baseImageFeatureFlag branch February 3, 2026 19:02
rhacs-bot pushed a commit that referenced this pull request Feb 3, 2026
@daynewlee @github-actions
ROX-32847: Enable ROX_BASE_IMAGE_DETECTION (#18809)
4ebed5d 
(cherry picked from commit 230a72b)
@rhacs-bot rhacs-bot mentioned this pull request Feb 3, 2026
Merged
@pedrottimark pedrottimark mentioned this pull request Mar 17, 2026
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvdm jvdm jvdm approved these changes

@pedrottimark pedrottimark Awaiting requested review from pedrottimark

@c-du c-du Awaiting requested review from c-du

@alwayshooin alwayshooin Awaiting requested review from alwayshooin

Assignees

No one assigned

Labels

backport release-4.10 backport PR to backport changes from master to release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daynewlee @rhacs-bot @jvdm