ROX-33686: Disable dynamic plugin for OpenShift >= 4.22#19527
Draft
dvail wants to merge 1 commit intodv/ROX-33021-better-plugin-dev-via-sensor-proxyfrom
Draft
ROX-33686: Disable dynamic plugin for OpenShift >= 4.22#19527dvail wants to merge 1 commit intodv/ROX-33021-better-plugin-dev-via-sensor-proxyfrom
dvail wants to merge 1 commit intodv/ROX-33021-better-plugin-dev-via-sensor-proxyfrom
Conversation
Due to OpenShift dropping PatternFly 5 support, disable the plugin for versions >= 4.21 by updating the webpack config dependency constraint. This change will be applied to the plugin manifest at build time. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-33021-better-plugin-dev-via-sensor-proxy #19527 +/- ##
================================================================================
Coverage 49.25% 49.25%
================================================================================
Files 2725 2725
Lines 205582 205582
================================================================================
+ Hits 101260 101263 +3
+ Misses 96784 96783 -1
+ Partials 7538 7536 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Images are ready for the commit at 68aec06. To use with deploy scripts, first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to OpenShift 4.22 dropping PatternFly 5 support, the dynamic plugin causes runtime issues. This PR updates the webpack config to disable the plugin for OpenShift >= 4.21 by modifying the
@console/pluginAPIdependency constraint. The version limit is applied to the plugin manifest at build time.Note: Currently set to <4.21.0 for testing on a 4.21.4 cluster. Will update to <4.22.0 after verification.
User-facing documentation
Testing and quality
Automated testing
No new tests needed - this is a webpack configuration change that affects plugin manifest generation.
How I validated my change