ROX-33770: Replace PropTypes in KeepBothSection component#19583
Merged
pedrottimark merged 1 commit intomasterfrom Mar 26, 2026
Merged
ROX-33770: Replace PropTypes in KeepBothSection component#19583pedrottimark merged 1 commit intomasterfrom
pedrottimark merged 1 commit intomasterfrom
Conversation
Contributor
|
Images are ready for the commit at bb81487. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19583 +/- ##
==========================================
- Coverage 49.26% 49.26% -0.01%
==========================================
Files 2735 2735
Lines 206138 206138
==========================================
- Hits 101550 101549 -1
- Misses 97041 97043 +2
+ Partials 7547 7546 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dvail
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up no-non-deprecated-PropTypes lint rule in #19548
Analysis
Sibling component has the usual component props type definition.
Solution
Edit KeepBothSection.tsx file.
PropTypeswithKeepBothSectionPropstype.stringtype fornameandvaluearguments.Edit RenamePolicySection.tsx file.
stringtype fornameandvaluearguments.Residue
Too bad, so sad that
handlerargument still has implicit any.Whenever we resume implicit any removal effort, I think we will rewrite:
Without partially applied function pattern, which seems to break encapsulation of the formik update.
That is, pass
updateResolutionfunction as a prop, if needed.Maybe even without formik
Fieldelement.User-facing documentation
Testing and quality
Automated testing
How I validated my change
npm run tscin ui/apps/platform folder.npm run lint:fast-devin ui/apps/platform folder.