chore(tests): Have tests set the flag so they run in CI#19685
Merged
dashrews78 merged 2 commits intomasterfrom Mar 30, 2026
Merged
chore(tests): Have tests set the flag so they run in CI#19685dashrews78 merged 2 commits intomasterfrom
dashrews78 merged 2 commits intomasterfrom
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 7f3b497. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19685 +/- ##
==========================================
+ Coverage 49.39% 49.65% +0.25%
==========================================
Files 2745 2745
Lines 207225 207225
==========================================
+ Hits 102365 102897 +532
+ Misses 97268 96677 -591
- Partials 7592 7651 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tests no longer require ROX_VIRTUAL_MACHINES_ENHANCED_DATA_MODEL=true to be set externally. Each test entry point now calls t.Setenv(features.VirtualMachinesEnhancedDataModel.EnvVar(), "true") before checking Enabled(), following an established codebase pattern. The 3 generated store tests (scan, component, cve) that lacked the feature flag guard entirely now also have the t.Setenv + skip pattern for consistency. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The previous commit added t.Setenv to all VM test files, but 3 of them are auto-generated by pg-bindings generator and must not be manually edited. This reverts those 3 files to match master, keeping the change only in the 5 non-generated test files. Partially generated by AI Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3bfa129 to
7f3b497
Compare
charmik-redhat
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests no longer require ROX_VIRTUAL_MACHINES_ENHANCED_DATA_MODEL=true
to be set externally. Each test entry point now calls
t.Setenv(features.VirtualMachinesEnhancedDataModel.EnvVar(), "true")
before checking Enabled(), following an established codebase pattern.
The 3 generated store tests (scan, component, cve) that lacked the
feature flag guard entirely now also have the t.Setenv + skip pattern
for consistency.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
This is only about running tests.