ROX-33608: add EnsureVirtualMachineExists to VM v2 datastore#19551
Draft
dashrews78 wants to merge 1 commit intodashrews/vm-v2-converters-33608from
Draft
ROX-33608: add EnsureVirtualMachineExists to VM v2 datastore#19551dashrews78 wants to merge 1 commit intodashrews/vm-v2-converters-33608from
dashrews78 wants to merge 1 commit intodashrews/vm-v2-converters-33608from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
9 tasks
23b41b9 to
ae3cb10
Compare
Contributor
|
Images are ready for the commit at 13ce987. To use with deploy scripts, first |
9 tasks
The scan index pipeline needs to insert a minimal VM record before upserting scan data to satisfy FK constraints (VirtualMachineScanV2.VmV2Id → VirtualMachineV2.Id). EnsureVirtualMachineExists checks if the VM row exists; if not, it inserts a minimal placeholder with just id and cluster_id, avoiding overwriting richer metadata from the VM pipeline. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
07beb4c to
3e3239d
Compare
ae3cb10 to
13ce987
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dashrews/vm-v2-converters-33608 #19551 +/- ##
================================================================
Coverage 49.30% 49.30%
================================================================
Files 2729 2729
Lines 206051 206068 +17
================================================================
+ Hits 101592 101602 +10
- Misses 96921 96931 +10
+ Partials 7538 7535 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scan index pipeline needs to insert a minimal VM record before
upserting scan data to satisfy FK constraints (VirtualMachineScanV2.VmV2Id
→ VirtualMachineV2.Id). EnsureVirtualMachineExists checks if the VM row
exists; if not, it inserts a minimal placeholder with just id and
cluster_id, avoiding overwriting richer metadata from the VM pipeline.
Partially generated by AI.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!