ROX-33608: add VirtualMachine v2 converters#19550
Draft
dashrews78 wants to merge 2 commits intodashrews/use-guest-os-constantfrom
Draft
ROX-33608: add VirtualMachine v2 converters#19550dashrews78 wants to merge 2 commits intodashrews/use-guest-os-constantfrom
dashrews78 wants to merge 2 commits intodashrews/use-guest-os-constantfrom
Conversation
…parts Add converters extracted from PR #19441 (ROX-33608): - internaltostorage.VirtualMachineV2(): sensor-internal VM to storage.VirtualMachineV2, extracting GuestOs from facts with "unknown" default - v1tov2storage.ScanPartsFromV1Scan(): splits v1 VirtualMachineScan into normalized v2 VMScanParts (scan, components, CVEs) with CVSS/NVD extraction, advisory/EPSS mapping, and highest-fixed-by version computation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Contributor
|
Images are ready for the commit at 07beb4c. To use with deploy scripts, first |
9 tasks
Replace direct proto field access (cve.PreferredCvss) with getter methods (cve.GetPreferredCvss()) to satisfy the protogetter linter. Partially generated by AI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dashrews/use-guest-os-constant #19550 +/- ##
==================================================================
+ Coverage 49.26% 49.29% +0.03%
==================================================================
Files 2727 2729 +2
Lines 205788 206018 +230
==================================================================
+ Hits 101375 101557 +182
- Misses 96881 96920 +39
- Partials 7532 7541 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add converters extracted from PR #19441 (ROX-33608):
extracting GuestOs from facts with "unknown" default
v2 VMScanParts (scan, components, CVEs) with CVSS/NVD extraction, advisory/EPSS
mapping, and highest-fixed-by version computation
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Description
change me!
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!