ROX-33893: glob patterns for header name#19723
Open
parametalol wants to merge 1 commit intomichael/telemetry-requestparam-refactoringfrom
Open
ROX-33893: glob patterns for header name#19723parametalol wants to merge 1 commit intomichael/telemetry-requestparam-refactoringfrom
parametalol wants to merge 1 commit intomichael/telemetry-requestparam-refactoringfrom
Conversation
9 tasks
9 tasks
Contributor
|
Images are ready for the commit at 8050edc. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## michael/telemetry-requestparam-refactoring #19723 +/- ##
===========================================================================
Coverage 49.58% 49.58%
===========================================================================
Files 2756 2756
Lines 207951 207969 +18
===========================================================================
+ Hits 103117 103128 +11
- Misses 97172 97178 +6
- Partials 7662 7663 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2e708df to
27967f6
Compare
737025b to
8050edc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support glob patterns in telemetry header names, not just values. Previously, campaigns could only match exact header names. Now both header names and values support globs (e.g.,
"Rh-*": NoHeaderOrAnyValue).Key changes:
APICallCampaignCriterion.Headers:map[string]glob.Pattern->map[glob.Pattern]glob.PatternHeaders.GetAll: matches both header names and values using globs"Rh-*"pattern instead of hardcoded header nameMotivation:
ServiceNow sets headers with a common
Rh-prefix, but the exact name may vary. Glob patterns for header names allow tracking related headers without hardcoding each variant.User-facing documentation
Testing and quality
Automated testing
How I validated my change
Headersfield"Rh-*"pattern matchinggo test ./pkg/telemetry/phonehome/... ./central/telemetry/centralclient/...Current dependencies on/for this PR: