Skip to content

ROX-33878: bump pgx to v5#19878

Open
BradLugo wants to merge 2 commits intorelease-4.8from
backport-15851-to-release-4.8
Open

ROX-33878: bump pgx to v5#19878
BradLugo wants to merge 2 commits intorelease-4.8from
backport-15851-to-release-4.8

Conversation

@BradLugo
Copy link
Copy Markdown
Contributor

@BradLugo BradLugo commented Apr 7, 2026 •
edited
Loading

Backport 2fe6390 from #15851.

Resolves ROX-33878 (with explanation).

@BradLugo BradLugo requested a review from a team as a code owner April 7, 2026 20:38
@github-actions github-actions bot added area/scanner backport PR to backport changes from master to release branch labels Apr 7, 2026
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Apr 7, 2026 •
edited
Loading

Images are ready for the commit at 8625939.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.10-4-g8625939e45.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.73%. Comparing base (5149581) to head (8625939).

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-4.8   #19878   +/-   ##
============================================
  Coverage        48.73%   48.73%           
============================================
  Files             2595     2595           
  Lines           190828   190828           
============================================
  Hits             93002    93002           
  Misses           90513    90513           
  Partials          7313     7313
Flag Coverage Δ
go-unit-tests 48.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BradLugo BradLugo force-pushed the backport-15851-to-release-4.8 branch from 2746008 to a05d941 Compare April 8, 2026 19:15
@BradLugo BradLugo force-pushed the backport-15851-to-release-4.8 branch from a05d941 to 8625939 Compare April 8, 2026 19:19
@BradLugo
Copy link
Copy Markdown
Contributor Author

BradLugo commented Apr 8, 2026

Note for reviewer(s): 8625939 is a bespoke change for 4.8 compatibility.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

@BradLugo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-dev-preview-scanner-v4-install-tests 8625939 link false /test ocp-dev-preview-scanner-v4-install-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BradLugo BradLugo added auto-retest PRs with this label will be automatically retested if prow checks fails and removed auto-retest PRs with this label will be automatically retested if prow checks fails labels Apr 9, 2026
@BradLugo
Copy link
Copy Markdown
Contributor Author

BradLugo commented Apr 9, 2026

Looks like ocp-dev-preview-scanner-v4-install-tests has been failing pretty consistently on release-4.8.

@dcaravel
Copy link
Copy Markdown
Contributor

dcaravel commented Apr 9, 2026

Looks like ocp-dev-preview-scanner-v4-install-tests has been failing pretty consistently on release-4.8.

Seems unrelated - collector readiness.

@janisz janisz changed the title ROX-29860: bump pgx to v5 ROX-33878: bump pgx to v5 Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcaravel dcaravel dcaravel approved these changes

Assignees

No one assigned

Labels

area/scanner backport PR to backport changes from master to release branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BradLugo @rhacs-bot @dcaravel @RTann